Merge pull request #26084 from nextcloud/backport/26079/stable21

[stable21] Chunk the array of phone numbers

lib/private/Accounts/AccountManager.php

@@ -229,19 +229,23 @@ class AccountManager implements IAccountManager {
 	}
 
 	public function searchUsers(string $property, array $values): array {
+		$chunks = array_chunk($values, 500);
 		$query = $this->connection->getQueryBuilder();
 		$query->select('*')
 			->from($this->dataTable)
 			->where($query->expr()->eq('name', $query->createNamedParameter($property)))
-			->andWhere($query->expr()->in('value', $query->createNamedParameter($values, IQueryBuilder::PARAM_STR_ARRAY)));
+			->andWhere($query->expr()->in('value', $query->createParameter('values')));
 
-		$result = $query->execute();
 		$matches = [];
+		foreach ($chunks as $chunk) {
+			$query->setParameter('values', $chunk, IQueryBuilder::PARAM_STR_ARRAY);
+			$result = $query->execute();
 
 			while ($row = $result->fetch()) {
 				$matches[$row['value']] = $row['uid'];
 			}
 			$result->closeCursor();
+		}
 
 		return $matches;
 	}

tests/lib/Accounts/AccountManagerTest.php

@@ -34,12 +34,12 @@ use Symfony\Component\EventDispatcher\GenericEvent;
 use Test\TestCase;
 
 /**
- * Class AccountsManagerTest
+ * Class AccountManagerTest
  *
  * @group DB
  * @package Test\Accounts
  */
-class AccountsManagerTest extends TestCase {
+class AccountManagerTest extends TestCase {
 
 	/** @var  \OCP\IDBConnection */
 	private $connection;