reduce adressbook change events and handling

... from four to one on avatar updates

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
This commit is contained in:
Arthur Schiwon 2019-09-04 13:36:08 +02:00
parent 0e19e55e24
commit 3ce5d4e545
No known key found for this signature in database
GPG Key ID: 7424F1874854DF23
2 changed files with 6 additions and 4 deletions

View File

@ -253,7 +253,7 @@ class User_Proxy extends Proxy implements \OCP\IUserBackend, \OCP\UserInterface,
* @return boolean either the user can or cannot * @return boolean either the user can or cannot
*/ */
public function canChangeAvatar($uid) { public function canChangeAvatar($uid) {
return $this->handleRequest($uid, 'canChangeAvatar', array($uid)); return $this->handleRequest($uid, 'canChangeAvatar', [$uid], true);
} }
/** /**

View File

@ -97,7 +97,7 @@ class UserAvatar extends Avatar {
$this->validateAvatar($img); $this->validateAvatar($img);
$this->remove(); $this->remove(true);
$type = $this->getAvatarImageType($img); $type = $this->getAvatarImageType($img);
$file = $this->folder->newFile('avatar.' . $type); $file = $this->folder->newFile('avatar.' . $type);
$file->putContent($data); $file->putContent($data);
@ -193,7 +193,7 @@ class UserAvatar extends Avatar {
* @throws \OCP\Files\NotPermittedException * @throws \OCP\Files\NotPermittedException
* @throws \OCP\PreConditionNotMetException * @throws \OCP\PreConditionNotMetException
*/ */
public function remove() { public function remove(bool $silent = false) {
$avatars = $this->folder->getDirectoryListing(); $avatars = $this->folder->getDirectoryListing();
$this->config->setUserValue($this->user->getUID(), 'avatar', 'version', $this->config->setUserValue($this->user->getUID(), 'avatar', 'version',
@ -203,7 +203,9 @@ class UserAvatar extends Avatar {
$avatar->delete(); $avatar->delete();
} }
$this->config->setUserValue($this->user->getUID(), 'avatar', 'generated', 'true'); $this->config->setUserValue($this->user->getUID(), 'avatar', 'generated', 'true');
$this->user->triggerChange('avatar', ''); if(!$silent) {
$this->user->triggerChange('avatar', '');
}
} }
/** /**