mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix DAV mimetype search 

Fixes #15048
Catches the case where a full mimetype is sumbitted in the where like
clause. Before we didn't catch this and it was just forwarded as is
causing invalid queries.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
This commit is contained in:
Roeland Jago Douma 2019-10-28 21:56:05 +01:00 committed by Backportbot
parent a7de52e9d9
commit 3ce9f0013a
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lib/private/Files/Cache/QuerySearchHelper.php
View File

@ -136,16 +136,19 @@ class QuerySearchHelper {
$type = $operator->getType(); $type = $operator->getType();
if ($field === 'mimetype') { if ($field === 'mimetype') {
if ($operator->getType() === ISearchComparison::COMPARE_EQUAL) { if ($operator->getType() === ISearchComparison::COMPARE_EQUAL) {
$value = $this->mimetypeLoader->getId($value); $value = (int)$this->mimetypeLoader->getId($value);
} else if ($operator->getType() === ISearchComparison::COMPARE_LIKE) { } else if ($operator->getType() === ISearchComparison::COMPARE_LIKE) {
// transform "mimetype='foo/%'" to "mimepart='foo'" // transform "mimetype='foo/%'" to "mimepart='foo'"
if (preg_match('|(.+)/%|', $value, $matches)) { if (preg_match('|(.+)/%|', $value, $matches)) {
$field = 'mimepart'; $field = 'mimepart';
$value = $this->mimetypeLoader->getId($matches[1]); $value = (int)$this->mimetypeLoader->getId($matches[1]);
$type = ISearchComparison::COMPARE_EQUAL; $type = ISearchComparison::COMPARE_EQUAL;
} } else if (strpos($value, '%') !== false) {
if (strpos($value, '%') !== false) {
throw new \InvalidArgumentException('Unsupported query value for mimetype: ' . $value . ', only values in the format "mime/type" or "mime/%" are supported'); throw new \InvalidArgumentException('Unsupported query value for mimetype: ' . $value . ', only values in the format "mime/type" or "mime/%" are supported');
} else {
$field = 'mimetype';
$value = (int)$this->mimetypeLoader->getId($value);
$type = ISearchComparison::COMPARE_EQUAL;
} }
} }
} else if ($field === 'favorite') { } else if ($field === 'favorite') {