mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #23929 from nextcloud/techdebt/noid/deprecate-prepare-and-execute-audited-as-they-leak-cursors 

Deprecate OC_DB::prepare and OC_DB::executeAudited as they leak cursors
This commit is contained in:
Morris Jobke 2020-11-06 16:24:29 +01:00 committed by GitHub
parent 9e2ced609e a847aea19c
commit 3f88ab8252
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/private/legacy/OC_DB.php
View File

@ -55,6 +55,7 @@ class OC_DB {
* @param bool|null $isManipulation * @param bool|null $isManipulation
* @throws \OC\DatabaseException * @throws \OC\DatabaseException
* @return OC_DB_StatementWrapper prepared SQL query * @return OC_DB_StatementWrapper prepared SQL query
* @depreacted 21.0.0 Please use \OCP\IDBConnection::getQueryBuilder() instead
* *
* SQL query via Doctrine prepare(), needs to be execute()'d! * SQL query via Doctrine prepare(), needs to be execute()'d!
*/ */
@ -112,6 +113,7 @@ class OC_DB {
* @param array $parameters * @param array $parameters
* @return OC_DB_StatementWrapper * @return OC_DB_StatementWrapper
* @throws \OC\DatabaseException * @throws \OC\DatabaseException
* @depreacted 21.0.0 Please use \OCP\IDBConnection::getQueryBuilder() instead
*/ */
public static function executeAudited($stmt, array $parameters = []) { public static function executeAudited($stmt, array $parameters = []) {
if (is_string($stmt)) { if (is_string($stmt)) {