show better quota warning for group folders and external storage

instead of showing the generic 'Your storage is full' message, better explain that it's the group folder/external storage that is full

Signed-off-by: Robin Appelman <robin@icewind.nl>
This commit is contained in:
Robin Appelman 2020-08-25 16:05:16 +02:00 committed by backportbot[bot]
parent c9a1379bdf
commit 4025b95e03
3 changed files with 40 additions and 15 deletions

View File

@ -72,6 +72,7 @@
$('#free_space').val(response.data.freeSpace); $('#free_space').val(response.data.freeSpace);
$('#upload.button').attr('data-original-title', response.data.maxHumanFilesize); $('#upload.button').attr('data-original-title', response.data.maxHumanFilesize);
$('#usedSpacePercent').val(response.data.usedSpacePercent); $('#usedSpacePercent').val(response.data.usedSpacePercent);
$('#usedSpacePercent').data('mount-type', response.data.mountType);
$('#owner').val(response.data.owner); $('#owner').val(response.data.owner);
$('#ownerDisplayName').val(response.data.ownerDisplayName); $('#ownerDisplayName').val(response.data.ownerDisplayName);
Files.displayStorageWarnings(); Files.displayStorageWarnings();
@ -155,21 +156,30 @@
var usedSpacePercent = $('#usedSpacePercent').val(), var usedSpacePercent = $('#usedSpacePercent').val(),
owner = $('#owner').val(), owner = $('#owner').val(),
ownerDisplayName = $('#ownerDisplayName').val(); ownerDisplayName = $('#ownerDisplayName').val(),
mountType = $('#usedSpacePercent').data('mount-type');
if (usedSpacePercent > 98) { if (usedSpacePercent > 98) {
if (owner !== OC.getCurrentUser().uid) { if (owner !== OC.getCurrentUser().uid) {
OC.Notification.show(t('files', 'Storage of {owner} is full, files can not be updated or synced anymore!', OC.Notification.show(t('files', 'Storage of {owner} is full, files can not be updated or synced anymore!',
{owner: ownerDisplayName}), {type: 'error'} {owner: ownerDisplayName}), {type: 'error'}
); );
return; } else if (mountType === 'group') {
OC.Notification.show(t('files',
'This group folder is full, files can not be updated or synced anymore!'),
{type: 'error'}
);
} else if (mountType === 'external') {
OC.Notification.show(t('files',
'This external storage is full, files can not be updated or synced anymore!'),
{type : 'error'}
);
} else {
OC.Notification.show(t('files',
'Your storage is full, files can not be updated or synced anymore!'),
{type: 'error'}
);
} }
OC.Notification.show(t('files', } else if (usedSpacePercent > 90) {
'Your storage is full, files can not be updated or synced anymore!'),
{type : 'error'}
);
return;
}
if (usedSpacePercent > 90) {
if (owner !== OC.getCurrentUser().uid) { if (owner !== OC.getCurrentUser().uid) {
OC.Notification.show(t('files', 'Storage of {owner} is almost full ({usedSpacePercent}%)', OC.Notification.show(t('files', 'Storage of {owner} is almost full ({usedSpacePercent}%)',
{ {
@ -180,12 +190,24 @@
type: 'error' type: 'error'
} }
); );
return; } else if (mountType === 'group') {
OC.Notification.show(t('files',
'This group folder is almost full ({usedSpacePercent}%)',
{usedSpacePercent: usedSpacePercent}),
{type : 'error'}
);
} else if (mountType === 'external') {
OC.Notification.show(t('files',
'This external storage is almost full ({usedSpacePercent}%)',
{usedSpacePercent: usedSpacePercent}),
{type : 'error'}
);
} else {
OC.Notification.show(t('files', 'Your storage is almost full ({usedSpacePercent}%)',
{usedSpacePercent: usedSpacePercent}),
{type : 'error'}
);
} }
OC.Notification.show(t('files', 'Your storage is almost full ({usedSpacePercent}%)',
{usedSpacePercent: usedSpacePercent}),
{type : 'error'}
);
} }
}, },

View File

@ -63,6 +63,7 @@ class Helper {
'usedSpacePercent' => (int)$storageInfo['relative'], 'usedSpacePercent' => (int)$storageInfo['relative'],
'owner' => $storageInfo['owner'], 'owner' => $storageInfo['owner'],
'ownerDisplayName' => $storageInfo['ownerDisplayName'], 'ownerDisplayName' => $storageInfo['ownerDisplayName'],
'mountType' => $storageInfo['mountType'],
]; ];
} }

View File

@ -495,7 +495,8 @@ class OC_Helper {
$used = 0; $used = 0;
} }
$quota = \OCP\Files\FileInfo::SPACE_UNLIMITED; $quota = \OCP\Files\FileInfo::SPACE_UNLIMITED;
$storage = $rootInfo->getStorage(); $mount = $rootInfo->getMountPoint();
$storage = $mount->getStorage();
$sourceStorage = $storage; $sourceStorage = $storage;
if ($storage->instanceOfStorage('\OCA\Files_Sharing\SharedStorage')) { if ($storage->instanceOfStorage('\OCA\Files_Sharing\SharedStorage')) {
$includeExtStorage = false; $includeExtStorage = false;
@ -553,6 +554,7 @@ class OC_Helper {
'relative' => $relative, 'relative' => $relative,
'owner' => $ownerId, 'owner' => $ownerId,
'ownerDisplayName' => $ownerDisplayName, 'ownerDisplayName' => $ownerDisplayName,
'mountType' => $mount->getMountType()
]; ];
} }