From 56efd687abf4551d782114175e0ff2567e16aad2 Mon Sep 17 00:00:00 2001 From: Daniel Kesselberg Date: Sun, 23 Feb 2020 18:53:17 +0100 Subject: [PATCH] Check that username and password are present. Signed-off-by: Daniel Kesselberg --- lib/base.php | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/base.php b/lib/base.php index b0991307dd..1d94468565 100644 --- a/lib/base.php +++ b/lib/base.php @@ -1077,10 +1077,12 @@ class OC { ); foreach ($vars as $var) { if (isset($_SERVER[$var]) && preg_match('/Basic\s+(.*)$/i', $_SERVER[$var], $matches)) { - list($name, $password) = explode(':', base64_decode($matches[1]), 2); - $_SERVER['PHP_AUTH_USER'] = $name; - $_SERVER['PHP_AUTH_PW'] = $password; - break; + $credentials = explode(':', base64_decode($matches[1]), 2); + if (count($credentials) === 2) { + $_SERVER['PHP_AUTH_USER'] = $credentials[0]; + $_SERVER['PHP_AUTH_PW'] = $credentials[1]; + break; + } } } }