mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #8769 from nextcloud/admin_audit_strict 

Make admin_audit strict
This commit is contained in:
Morris Jobke 2018-03-12 11:57:37 +01:00 committed by GitHub
parent 4e56a02450 4d5830c4aa
commit 430c478ba3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
12 changed files with 22 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
apps/admin_audit/appinfo/app.php
View File

@ -1,4 +1,5 @@
<?php <?php
declare(strict_types=1);
/** /**
* @copyright Copyright (c) 2016 Bjoern Schiessle <bjoern@schiessle.org> * @copyright Copyright (c) 2016 Bjoern Schiessle <bjoern@schiessle.org>
* @copyright Copyright (c) 2017 Lukas Reschke <lukas@statuscode.ch> * @copyright Copyright (c) 2017 Lukas Reschke <lukas@statuscode.ch>

5
apps/admin_audit/lib/Actions/Action.php
View File

@ -1,4 +1,5 @@
<?php <?php
declare(strict_types=1);
/** /**
* @copyright Copyright (c) 2016 Lukas Reschke <lukas@statuscode.ch> * @copyright Copyright (c) 2016 Lukas Reschke <lukas@statuscode.ch>
* *
@ -45,10 +46,10 @@ class Action {
* @param array $elements * @param array $elements
* @param bool $obfuscateParameters * @param bool $obfuscateParameters
*/ */
public function log($text, public function log(string $text,
array $params, array $params,
array $elements, array $elements,
$obfuscateParameters = false) { bool $obfuscateParameters = false) {
foreach($elements as $element) { foreach($elements as $element) {
if(!isset($params[$element])) { if(!isset($params[$element])) {
if ($obfuscateParameters) { if ($obfuscateParameters) {

7
apps/admin_audit/lib/Actions/AppManagement.php
View File

@ -1,4 +1,5 @@
<?php <?php
declare(strict_types=1);
/** /**
* @copyright Copyright (c) 2017 Joas Schilling <coding@schilljs.com> * @copyright Copyright (c) 2017 Joas Schilling <coding@schilljs.com>
* *
@ -28,7 +29,7 @@ class AppManagement extends Action {
/** /**
* @param string $appName * @param string $appName
*/ */
public function enableApp($appName) { public function enableApp(string $appName) {
$this->log('App "%s" enabled', $this->log('App "%s" enabled',
['app' => $appName], ['app' => $appName],
['app'] ['app']
@ -39,7 +40,7 @@ class AppManagement extends Action {
* @param string $appName * @param string $appName
* @param string[] $groups * @param string[] $groups
*/ */
public function enableAppForGroups($appName, array $groups) { public function enableAppForGroups(string $appName, array $groups) {
$this->log('App "%s" enabled for groups: %s', $this->log('App "%s" enabled for groups: %s',
['app' => $appName, 'groups' => implode(', ', $groups)], ['app' => $appName, 'groups' => implode(', ', $groups)],
['app', 'groups'] ['app', 'groups']
@ -49,7 +50,7 @@ class AppManagement extends Action {
/** /**
* @param string $appName * @param string $appName
*/ */
public function disableApp($appName) { public function disableApp(string $appName) {
$this->log('App "%s" disabled', $this->log('App "%s" disabled',
['app' => $appName], ['app' => $appName],
['app'] ['app']

1
apps/admin_audit/lib/Actions/Auth.php
View File

@ -1,4 +1,5 @@
<?php <?php
declare(strict_types=1);
/** /**
* @copyright Copyright (c) 2016 Lukas Reschke <lukas@statuscode.ch> * @copyright Copyright (c) 2016 Lukas Reschke <lukas@statuscode.ch>
* *

3
apps/admin_audit/lib/Actions/Console.php
View File

@ -1,4 +1,5 @@
<?php <?php
declare(strict_types=1);
/** /**
* @copyright Copyright (c) 2017 Joas Schilling <coding@schilljs.com> * @copyright Copyright (c) 2017 Joas Schilling <coding@schilljs.com>
* *
@ -28,7 +29,7 @@ class Console extends Action {
/** /**
* @param $arguments * @param $arguments
*/ */
public function runCommand($arguments) { public function runCommand(array $arguments) {
if ($arguments[1] === '_completion') { if ($arguments[1] === '_completion') {
// Don't log autocompletion // Don't log autocompletion
return; return;

1
apps/admin_audit/lib/Actions/Files.php
View File

@ -1,4 +1,5 @@
<?php <?php
declare(strict_types=1);
/** /**
* @copyright Copyright (c) 2016 Lukas Reschke <lukas@statuscode.ch> * @copyright Copyright (c) 2016 Lukas Reschke <lukas@statuscode.ch>
* *

1
apps/admin_audit/lib/Actions/GroupManagement.php
View File

@ -1,4 +1,5 @@
<?php <?php
declare(strict_types=1);
/** /**
* @copyright Copyright (c) 2016 Bjoern Schiessle <bjoern@schiessle.org> * @copyright Copyright (c) 2016 Bjoern Schiessle <bjoern@schiessle.org>
* *

1
apps/admin_audit/lib/Actions/Sharing.php
View File

@ -1,4 +1,5 @@
<?php <?php
declare(strict_types=1);
/** /**
* @copyright Copyright (c) 2016 Lukas Reschke <lukas@statuscode.ch> * @copyright Copyright (c) 2016 Lukas Reschke <lukas@statuscode.ch>
* *

5
apps/admin_audit/lib/Actions/Trashbin.php
View File

@ -1,4 +1,5 @@
<?php <?php
declare(strict_types=1);
/** /**
* @copyright Copyright (c) 2016 Bjoern Schiessle <bjoern@schiessle.org> * @copyright Copyright (c) 2016 Bjoern Schiessle <bjoern@schiessle.org>
* *
@ -27,13 +28,13 @@ namespace OCA\AdminAudit\Actions;
class Trashbin extends Action { class Trashbin extends Action {
public function delete($params) { public function delete(array $params) {
$this->log('File "%s" deleted from trash bin.', $this->log('File "%s" deleted from trash bin.',
['path' => $params['path']], ['path'] ['path' => $params['path']], ['path']
); );
} }
public function restore($params) { public function restore(array $params) {
$this->log('File "%s" restored from trash bin.', $this->log('File "%s" restored from trash bin.',
['path' => $params['filePath']], ['path'] ['path' => $params['filePath']], ['path']
); );

1
apps/admin_audit/lib/Actions/UserManagement.php
View File

@ -1,4 +1,5 @@
<?php <?php
declare(strict_types=1);
/** /**
* @copyright Copyright (c) 2016 Lukas Reschke <lukas@statuscode.ch> * @copyright Copyright (c) 2016 Lukas Reschke <lukas@statuscode.ch>
* *

5
apps/admin_audit/lib/Actions/Versions.php
View File

@ -1,4 +1,5 @@
<?php <?php
declare(strict_types=1);
/** /**
* @copyright Bjoern Schiessle <bjoern@schiessle.org> * @copyright Bjoern Schiessle <bjoern@schiessle.org>
* *
@ -27,7 +28,7 @@ namespace OCA\AdminAudit\Actions;
class Versions extends Action { class Versions extends Action {
public function rollback($params) { public function rollback(array $params) {
$this->log('Version "%s" of "%s" was restored.', $this->log('Version "%s" of "%s" was restored.',
[ [
'version' => $params['revision'], 'version' => $params['revision'],
@ -37,7 +38,7 @@ class Versions extends Action {
); );
} }
public function delete($params) { public function delete(array $params) {
$this->log('Version "%s" was deleted.', $this->log('Version "%s" was deleted.',
['path' => $params['path']], ['path' => $params['path']],
['path'] ['path']

1
apps/admin_audit/lib/AppInfo/Application.php
View File

@ -1,4 +1,5 @@
<?php <?php
declare(strict_types=1);
/** /**
* @copyright Copyright (c) 2017 Joas Schilling <coding@schilljs.com> * @copyright Copyright (c) 2017 Joas Schilling <coding@schilljs.com>
* *