From 5660f99592b313e423c0b7d9682dacb1896ce102 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rn=20Friedrich=20Dreyer?= Date: Tue, 13 Aug 2013 22:58:27 +0200 Subject: [PATCH 1/3] add PERMISSIONS_ALL summary --- core/js/js.js | 1 + 1 file changed, 1 insertion(+) diff --git a/core/js/js.js b/core/js/js.js index 1d1711383f..64b5556987 100644 --- a/core/js/js.js +++ b/core/js/js.js @@ -157,6 +157,7 @@ var OC={ PERMISSION_UPDATE:2, PERMISSION_DELETE:8, PERMISSION_SHARE:16, + PERMISSION_ALL:31, webroot:oc_webroot, appswebroots:(typeof oc_appswebroots !== 'undefined') ? oc_appswebroots:false, currentUser:(typeof oc_current_user!=='undefined')?oc_current_user:false, From ca95a475d5fa81f3b3a8b5dcbce87189b79fc56e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rn=20Friedrich=20Dreyer?= Date: Tue, 13 Aug 2013 22:58:47 +0200 Subject: [PATCH 2/3] use edit & reshare permission as default --- core/js/share.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/core/js/share.js b/core/js/share.js index b4b5159b0b..622b23d05a 100644 --- a/core/js/share.js +++ b/core/js/share.js @@ -256,8 +256,8 @@ OC.Share={ var shareType = selected.item.value.shareType; var shareWith = selected.item.value.shareWith; $(this).val(shareWith); - // Default permissions are Read and Share - var permissions = OC.PERMISSION_READ | OC.PERMISSION_SHARE; + // Default permissions are Edit and Share (all) + var permissions = OC.PERMISSION_ALL; OC.Share.share(itemType, itemSource, shareType, shareWith, permissions, function() { OC.Share.addShareWith(shareType, shareWith, selected.item.label, permissions, possiblePermissions); $('#shareWith').val(''); From 11a404b90b8676cd38b1f6dbfbc7ca074f9a31ab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B6rn=20Friedrich=20Dreyer?= Date: Wed, 14 Aug 2013 00:25:07 +0200 Subject: [PATCH 3/3] comment clarification --- core/js/share.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/js/share.js b/core/js/share.js index 622b23d05a..a0ae39fffe 100644 --- a/core/js/share.js +++ b/core/js/share.js @@ -256,7 +256,7 @@ OC.Share={ var shareType = selected.item.value.shareType; var shareWith = selected.item.value.shareWith; $(this).val(shareWith); - // Default permissions are Edit and Share (all) + // Default permissions are Edit (CRUD) and Share var permissions = OC.PERMISSION_ALL; OC.Share.share(itemType, itemSource, shareType, shareWith, permissions, function() { OC.Share.addShareWith(shareType, shareWith, selected.item.label, permissions, possiblePermissions);