Merge pull request #21671 from nextcloud/revert-21095-backport/21090/stable19

Revert "[stable19] Do not read certificate bundle from data dir by default"

lib/private/Http/Client/Client.php

@@ -93,20 +93,20 @@ class Client implements IClient {
 	}
 
 	private function getCertBundle(): string {
+		if ($this->certificateManager->listCertificates() !== []) {
+			return $this->certificateManager->getAbsoluteBundlePath();
+		}
+
 		// If the instance is not yet setup we need to use the static path as
 		// $this->certificateManager->getAbsoluteBundlePath() tries to instantiiate
 		// a view
-		if ($this->config->getSystemValue('installed', false) === false) {
-			return \OC::$SERVERROOT . '/resources/config/ca-bundle.crt';
+		if ($this->config->getSystemValue('installed', false)) {
+			return $this->certificateManager->getAbsoluteBundlePath(null);
 		}
 
-		if ($this->certificateManager->listCertificates() === []) {
 		return \OC::$SERVERROOT . '/resources/config/ca-bundle.crt';
 	}
 
-		return $this->certificateManager->getAbsoluteBundlePath();
-	}
-
 	/**
 	 * Returns a null or an associative array specifiying the proxy URI for
 	 * 'http' and 'https' schemes, in addition to a 'no' key value pair

tests/lib/Http/Client/ClientTest.php

@@ -460,8 +460,9 @@ class ClientTest extends \Test\TestCase {
 			->with('installed', false)
 			->willReturn(false);
 		$this->certificateManager
-			->expects($this->never())
-			->method('listCertificates');
+			->expects($this->once())
+			->method('listCertificates')
+			->willReturn([]);
 
 		$this->assertEquals([
 			'verify' => \OC::$SERVERROOT . '/resources/config/ca-bundle.crt',