From b1fd72c1cf499188db7ddc26c925d7d5eed7aa2a Mon Sep 17 00:00:00 2001 From: Roeland Jago Douma Date: Fri, 2 Nov 2018 22:45:25 +0100 Subject: [PATCH] Set the filemodel before rending the detailsview fixes #10934 Else it triggers the rendering two times. Resulting is weird state in for example the comments. Because the comments for OLD_FILEID are retrieved but then the model is changed to NEW_FILEID. But the old comments still get in and get parsed. Signed-off-by: Roeland Jago Douma --- apps/files/js/filelist.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/files/js/filelist.js b/apps/files/js/filelist.js index 9cc1856d52..8b12cce51d 100644 --- a/apps/files/js/filelist.js +++ b/apps/files/js/filelist.js @@ -576,8 +576,8 @@ } this._currentFileModel = model; - this._detailsView.render(); this._detailsView.setFileInfo(model); + this._detailsView.render(); this._detailsView.$el.scrollTop(0); },