diff --git a/core/Controller/NavigationController.php b/core/Controller/NavigationController.php index 2397fb3c7b..eb3b0968da 100644 --- a/core/Controller/NavigationController.php +++ b/core/Controller/NavigationController.php @@ -55,7 +55,7 @@ class NavigationController extends OCSController { if ($absolute) { $navigation = $this->rewriteToAbsoluteUrls($navigation); } - + $navigation = array_values($navigation); $etag = $this->generateETag($navigation); if ($this->request->getHeader('If-None-Match') === $etag) { return new DataResponse([], Http::STATUS_NOT_MODIFIED); @@ -77,6 +77,7 @@ class NavigationController extends OCSController { if ($absolute) { $navigation = $this->rewriteToAbsoluteUrls($navigation); } + $navigation = array_values($navigation); $etag = $this->generateETag($navigation); if ($this->request->getHeader('If-None-Match') === $etag) { return new DataResponse([], Http::STATUS_NOT_MODIFIED); diff --git a/settings/js/apps.js b/settings/js/apps.js index c9b1ea6b8d..641e8999b1 100644 --- a/settings/js/apps.js +++ b/settings/js/apps.js @@ -6,7 +6,7 @@ OC.Settings.Apps = OC.Settings.Apps || { if(response.ocs.meta.status === 'ok') { var addedApps = {}; var navEntries = response.ocs.data; - var container = $('#navigation #apps'); + var container = $('#navigation #apps ul'); // remove disabled apps for (var i = 0; i < navEntries.length; i++) { diff --git a/tests/Core/Controller/NavigationControllerTest.php b/tests/Core/Controller/NavigationControllerTest.php index 86173405c1..4095526fc0 100644 --- a/tests/Core/Controller/NavigationControllerTest.php +++ b/tests/Core/Controller/NavigationControllerTest.php @@ -69,7 +69,7 @@ class NavigationControllerTest extends TestCase { $this->navigationManager->expects($this->once()) ->method('getAll') ->with('link') - ->willReturn([ ['id' => 'files', 'href' => '/index.php/apps/files', 'icon' => 'icon' ] ]); + ->willReturn(['files' => ['id' => 'files', 'href' => '/index.php/apps/files', 'icon' => 'icon' ] ]); if ($absolute) { $this->urlGenerator->expects($this->any()) ->method('getBaseURL') @@ -102,7 +102,7 @@ class NavigationControllerTest extends TestCase { $this->navigationManager->expects($this->once()) ->method('getAll') ->with('settings') - ->willReturn([ ['id' => 'settings', 'href' => '/index.php/settings/user', 'icon' => '/core/img/settings.svg'] ]); + ->willReturn(['settings' => ['id' => 'settings', 'href' => '/index.php/settings/user', 'icon' => '/core/img/settings.svg'] ]); if ($absolute) { $this->urlGenerator->expects($this->any()) ->method('getBaseURL')