From 4dd72e9eb9128c873356023eb6c5f1a829745f25 Mon Sep 17 00:00:00 2001 From: Morris Jobke Date: Fri, 21 Apr 2017 11:30:00 -0500 Subject: [PATCH] Use RESPOND_NOT_FOUND for non existing user Signed-off-by: Morris Jobke --- apps/provisioning_api/lib/Controller/UsersController.php | 2 +- apps/provisioning_api/tests/Controller/UsersControllerTest.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/provisioning_api/lib/Controller/UsersController.php b/apps/provisioning_api/lib/Controller/UsersController.php index d2aeac540d..b1a1cf1c6b 100644 --- a/apps/provisioning_api/lib/Controller/UsersController.php +++ b/apps/provisioning_api/lib/Controller/UsersController.php @@ -790,7 +790,7 @@ class UsersController extends OCSController { $targetUser = $this->userManager->get($userId); if($targetUser === null) { - throw new OCSException('', \OCP\API::RESPOND_UNAUTHORISED); + throw new OCSException('', \OCP\API::RESPOND_NOT_FOUND); } // Check if admin / subadmin diff --git a/apps/provisioning_api/tests/Controller/UsersControllerTest.php b/apps/provisioning_api/tests/Controller/UsersControllerTest.php index 1d1cd97b6d..2eb3853d33 100644 --- a/apps/provisioning_api/tests/Controller/UsersControllerTest.php +++ b/apps/provisioning_api/tests/Controller/UsersControllerTest.php @@ -2707,7 +2707,7 @@ class UsersControllerTest extends TestCase { /** * @expectedException \OCP\AppFramework\OCS\OCSException - * @expectedExceptionCode 997 + * @expectedExceptionCode 998 */ public function testResendWelcomeMessageWithNotExistingTargetUser() { $this->userManager