mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #15127 from nextcloud/backport/15123/stable16 

[stable16] Improve the share link password error feedback with a red border
This commit is contained in:
Morris Jobke 2019-04-16 14:37:42 +02:00 committed by GitHub
parent d2e5368375 090c520d49
commit 4e5327f77a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
apps/files_sharing/js/dist/additionalScripts.js vendored
View File

File diff suppressed because one or more lines are too long

2
apps/files_sharing/js/dist/additionalScripts.js.map vendored
View File

File diff suppressed because one or more lines are too long

6
apps/files_sharing/src/style/sharetabview.scss
View File

@ -73,6 +73,12 @@
}
.popovermenu {
.linkPassMenu {
input.error {
border-color: var(--color-error) !important;
&[type="submit"] {
border-left: none;
}
}
.share-pass-submit {
width: auto !important;
}

2
core/js/dist/share_backend.js vendored
View File

File diff suppressed because one or more lines are too long

2
core/js/dist/share_backend.js.map vendored
View File

File diff suppressed because one or more lines are too long

4
core/js/sharedialoglinkshareview.js
View File

@ -352,6 +352,7 @@
}
var $input = $li.find('.linkPassText');
$input.removeClass('error');
$input.parent().find('input').removeClass('error');
var password = $input.val();
if ($li.find('.linkPassText').attr('placeholder') === PASSWORD_PLACEHOLDER_MESSAGE_OPTIONAL) {
@ -380,6 +381,9 @@
$loading.removeClass('inlineblock').addClass('hidden');
},
error: function(model, msg) {
// Add visual feedback to both the input and the submit button
$input.parent().find('input').addClass('error');
// destroy old tooltips
var $container = $input.parent();
$container.tooltip('destroy');