mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Implement OCP Since Check for classes and interfaces

This commit is contained in:
Morris Jobke 2015-07-27 10:49:45 +02:00
parent c9e22f70c8
commit 4efbf12fb8
1 changed files with 16 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
build/OCPSinceChecker.php
View File

@ -54,12 +54,22 @@ class SinceTagCheckVisitor extends \PhpParser\NodeVisitorAbstract {
/** @var \PhpParser\Comment\Doc[] $comments */
$comments = $node->getAttribute('comments');
if(count($comments) !== 0) {
$comment = $comments[count($comments) - 1];
$text = $comment->getText();
if(strpos($text, '@deprecated') !== false) {
$this->deprecatedClass = true;
}
if(count($comments) === 0) {
$this->errors[] = 'PHPDoc is needed for ' . $this->namespace . '\\' . $this->className . '::' . $node->name;
return;
}
$comment = $comments[count($comments) - 1];
$text = $comment->getText();
if(strpos($text, '@deprecated') !== false) {
$this->deprecatedClass = true;
}
if($this->deprecatedClass === false && strpos($text, '@since') === false && strpos($text, '@deprecated') === false) {
$type = $node instanceof \PhpParser\Node\Stmt\Interface_ ? 'interface' : 'class';
$this->errors[] = '@since or @deprecated tag is needed in PHPDoc for ' . $type . ' ' . $this->namespace . '\\' . $this->className;
return;
}
}