From 5247a0685d52b3889339cc5535b9b2a051ee03f2 Mon Sep 17 00:00:00 2001 From: Robin Appelman Date: Tue, 8 Sep 2015 15:33:52 +0200 Subject: [PATCH] clear up tests a bit --- .../lib/connector/sabre/requesttest/uploadtest.php | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/tests/lib/connector/sabre/requesttest/uploadtest.php b/tests/lib/connector/sabre/requesttest/uploadtest.php index b8cd44afda..8f39aff81b 100644 --- a/tests/lib/connector/sabre/requesttest/uploadtest.php +++ b/tests/lib/connector/sabre/requesttest/uploadtest.php @@ -8,6 +8,8 @@ namespace Test\Connector\Sabre\RequestTest; +use OC\AppFramework\Http; + class UploadTest extends RequestTest { public function testBasicUpload() { $user = $this->getUniqueID(); @@ -16,7 +18,7 @@ class UploadTest extends RequestTest { $this->assertFalse($view->file_exists('foo.txt')); $response = $this->request($view, $user, 'pass', 'PUT', '/foo.txt', 'asd'); - $this->assertEquals(201, $response->getStatus()); + $this->assertEquals(Http::STATUS_CREATED, $response->getStatus()); $this->assertTrue($view->file_exists('foo.txt')); $this->assertEquals('asd', $view->file_get_contents('foo.txt')); @@ -33,7 +35,7 @@ class UploadTest extends RequestTest { $response = $this->request($view, $user, 'pass', 'PUT', '/foo.txt', 'asd'); - $this->assertEquals(204, $response->getStatus()); + $this->assertEquals(Http::STATUS_NO_CONTENT, $response->getStatus()); $this->assertEquals('asd', $view->file_get_contents('foo.txt')); $info = $view->getFileInfo('foo.txt'); @@ -53,7 +55,7 @@ class UploadTest extends RequestTest { $response = $this->request($view, $user, 'pass', 'PUT', '/foo.txt-chunking-123-2-1', 'bar', ['OC-Chunked' => '1']); - $this->assertEquals(201, $response->getStatus()); + $this->assertEquals(Http::STATUS_CREATED, $response->getStatus()); $this->assertTrue($view->file_exists('foo.txt')); $this->assertEquals('asdbar', $view->file_get_contents('foo.txt')); @@ -70,12 +72,12 @@ class UploadTest extends RequestTest { $view->file_put_contents('foo.txt', 'bar'); $response = $this->request($view, $user, 'pass', 'PUT', '/foo.txt-chunking-123-2-0', 'asd', ['OC-Chunked' => '1']); - $this->assertEquals(201, $response->getStatus()); + $this->assertEquals(Http::STATUS_CREATED, $response->getStatus()); $this->assertEquals('bar', $view->file_get_contents('foo.txt')); $response = $this->request($view, $user, 'pass', 'PUT', '/foo.txt-chunking-123-2-1', 'bar', ['OC-Chunked' => '1']); - $this->assertEquals(201, $response->getStatus()); + $this->assertEquals(Http::STATUS_CREATED, $response->getStatus()); $this->assertEquals('asdbar', $view->file_get_contents('foo.txt')); @@ -91,7 +93,7 @@ class UploadTest extends RequestTest { $this->assertFalse($view->file_exists('foo.txt')); $response = $this->request($view, $user, 'pass', 'PUT', '/foo.txt-chunking-123-2-1', 'bar', ['OC-Chunked' => '1']); - $this->assertEquals(201, $response->getStatus()); + $this->assertEquals(Http::STATUS_CREATED, $response->getStatus()); $this->assertFalse($view->file_exists('foo.txt')); $response = $this->request($view, $user, 'pass', 'PUT', '/foo.txt-chunking-123-2-0', 'asd', ['OC-Chunked' => '1']);