From dbf4a4b844fa1e302b162bfbeea53bea229359f1 Mon Sep 17 00:00:00 2001 From: duritong Date: Sun, 29 Jan 2017 00:55:39 +0100 Subject: [PATCH] only chmod logfile if necessary otherwise e.g. on SELinux this will log an error, so we better avoid it if not necessary. --- lib/private/Log/File.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/private/Log/File.php b/lib/private/Log/File.php index d41ab83c80..4f18023613 100644 --- a/lib/private/Log/File.php +++ b/lib/private/Log/File.php @@ -116,7 +116,9 @@ class File { ); $entry = json_encode($entry); $handle = @fopen(self::$logFile, 'a'); - @chmod(self::$logFile, 0640); + if ((fileperms(self::$logFile) & 0777) != 0640) { + @chmod(self::$logFile, 0640); + } if ($handle) { fwrite($handle, $entry."\n"); fclose($handle);