clean up created groups after testing, and correct parameter order

This commit is contained in:
Arthur Schiwon 2014-06-24 21:56:08 +02:00
parent 121d52860e
commit 553c2ad33a
2 changed files with 10 additions and 11 deletions

View File

@ -104,9 +104,9 @@ abstract class Test_Group_Backend extends PHPUnit_Framework_TestCase {
} }
public function testSearchGroups() { public function testSearchGroups() {
$name1 = 'foobarbaz'; $name1 = $this->getGroupName('foobarbaz');
$name2 = 'bazbarfoo'; $name2 = $this->getGroupName('bazbarfoo');
$name3 = 'notme'; $name3 = $this->getGroupName('notme');
$this->backend->createGroup($name1); $this->backend->createGroup($name1);
$this->backend->createGroup($name2); $this->backend->createGroup($name2);
@ -114,9 +114,6 @@ abstract class Test_Group_Backend extends PHPUnit_Framework_TestCase {
$result = $this->backend->getGroups('bar'); $result = $this->backend->getGroups('bar');
$this->assertSame(2, count($result)); $this->assertSame(2, count($result));
$result = $this->backend->getDisplayNames('bar');
$this->assertSame(2, count($result));
} }
public function testSearchUsers() { public function testSearchUsers() {
@ -127,9 +124,9 @@ abstract class Test_Group_Backend extends PHPUnit_Framework_TestCase {
$name2 = 'bazbarfoo'; $name2 = 'bazbarfoo';
$name3 = 'notme'; $name3 = 'notme';
$this->backend->addToGroup($group, $name1); $this->backend->addToGroup($name1, $group);
$this->backend->addToGroup($group, $name2); $this->backend->addToGroup($name2, $group);
$this->backend->addToGroup($group, $name3); $this->backend->addToGroup($name3, $group);
$result = $this->backend->usersInGroup($group, 'bar'); $result = $this->backend->usersInGroup($group, 'bar');
$this->assertSame(2, count($result)); $this->assertSame(2, count($result));

View File

@ -28,8 +28,10 @@ class Test_Group_Database extends Test_Group_Backend {
* test cases can override this in order to clean up created groups * test cases can override this in order to clean up created groups
* @return string * @return string
*/ */
public function getGroupName() { public function getGroupName($name = null) {
$name=uniqid('test_'); if(is_null($name)) {
$name=uniqid('test_');
}
$this->groups[]=$name; $this->groups[]=$name;
return $name; return $name;
} }