mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add verbosity option to app:check-code 

* by default only lists files with errors
* option -v lists all files even if there are no errors
This commit is contained in:
Morris Jobke 2015-05-05 13:57:23 +02:00
parent 5aa3525479
commit 56b1c93a79
2 changed files with 18 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
core/command/app/checkcode.php
View File

@ -43,16 +43,27 @@ class CheckCode extends Command {
$appId = $input->getArgument('app-id');
$codeChecker = new \OC\App\CodeChecker();
$codeChecker->listen('CodeChecker', 'analyseFileBegin', function($params) use ($output) {
$output->writeln("<info>Analysing {$params}</info>");
if(OutputInterface::VERBOSITY_VERBOSE <= $output->getVerbosity()) {
$output->writeln("<info>Analysing {$params}</info>");
}
});
$codeChecker->listen('CodeChecker', 'analyseFileFinished', function($params) use ($output) {
$count = count($params);
$output->writeln(" {$count} errors");
usort($params, function($a, $b) {
$codeChecker->listen('CodeChecker', 'analyseFileFinished', function($filename, $errors) use ($output) {
$count = count($errors);
// show filename if the verbosity is low, but there are errors in a file
if($count > 0 && OutputInterface::VERBOSITY_VERBOSE > $output->getVerbosity()) {
$output->writeln("<info>Analysing {$filename}</info>");
}
// show error count if there are errros present or the verbosity is high
if($count > 0 || OutputInterface::VERBOSITY_VERBOSE <= $output->getVerbosity()) {
$output->writeln(" {$count} errors");
}
usort($errors, function($a, $b) {
return $a['line'] >$b['line'];
});
foreach($params as $p) {
foreach($errors as $p) {
$line = sprintf("%' 4d", $p['line']);
$output->writeln(" <error>line $line: {$p['disallowedToken']} - {$p['reason']}</error>");
}

2
lib/private/app/codechecker.php
View File

@ -118,7 +118,7 @@ class CodeChecker extends BasicEmitter {
/** @var SplFileInfo $file */
$this->emit('CodeChecker', 'analyseFileBegin', [$file->getPathname()]);
$fileErrors = $this->analyseFile($file);
$this->emit('CodeChecker', 'analyseFileFinished', [$fileErrors]);
$this->emit('CodeChecker', 'analyseFileFinished', [$file->getPathname(), $fileErrors]);
$errors = array_merge($fileErrors, $errors);
}