Code style and comment fixes

Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
This commit is contained in:
Michael Weimann 2019-02-10 10:31:46 +01:00
parent 6c52821389
commit 587a140c8a
No known key found for this signature in database
GPG Key ID: 34F0524D4DA694A1
3 changed files with 8 additions and 6 deletions

View File

@ -65,8 +65,10 @@ class PersonalInfo implements ISettings {
* @param IUserManager $userManager * @param IUserManager $userManager
* @param IGroupManager $groupManager * @param IGroupManager $groupManager
* @param AccountManager $accountManager * @param AccountManager $accountManager
* @param IAppManager $appManager
* @param IFactory $l10nFactory * @param IFactory $l10nFactory
* @param IL10N $l * @param IL10N $l
* @param EncryptionManager $encryptionManager
*/ */
public function __construct( public function __construct(
IConfig $config, IConfig $config,
@ -151,7 +153,7 @@ class PersonalInfo implements ISettings {
* *
* @return array * @return array
*/ */
private function getWhereIsYourDataParams() { private function getWhereIsYourDataParams(): array {
$adminContactConfigId = $this->config->getSystemValue(ServerInfo::SETTING_PROVIDER_ADMIN_CONTACT); $adminContactConfigId = $this->config->getSystemValue(ServerInfo::SETTING_PROVIDER_ADMIN_CONTACT);
$adminContact = $this->userManager->get($adminContactConfigId); $adminContact = $this->userManager->get($adminContactConfigId);

View File

@ -63,7 +63,7 @@ class ServerInfo implements ISettings {
/** /**
* @return TemplateResponse * @return TemplateResponse
*/ */
public function getForm() { public function getForm(): TemplateResponse {
$parameters = [ $parameters = [
'location' => $this->config->getSystemValue(self::SETTING_LOCATION), 'location' => $this->config->getSystemValue(self::SETTING_LOCATION),
'provider' => $this->config->getSystemValue(self::SETTING_PROVIDER), 'provider' => $this->config->getSystemValue(self::SETTING_PROVIDER),
@ -80,7 +80,7 @@ class ServerInfo implements ISettings {
* *
* @return array[] An array or arrays with the keys 'id' and 'displayName' * @return array[] An array or arrays with the keys 'id' and 'displayName'
*/ */
private function getAdminListValues() { private function getAdminListValues(): array {
$adminGroup = $this->groupManager->get('admin'); $adminGroup = $this->groupManager->get('admin');
$users = $adminGroup->getUsers(); $users = $adminGroup->getUsers();
@ -103,7 +103,7 @@ class ServerInfo implements ISettings {
* *
* @return string * @return string
*/ */
public function getSection() { public function getSection(): string {
return 'theming'; return 'theming';
} }
@ -114,7 +114,7 @@ class ServerInfo implements ISettings {
* the admin section. The forms are arranged in ascending order of the * the admin section. The forms are arranged in ascending order of the
* priority values. It is required to return a value between 0 and 100. * priority values. It is required to return a value between 0 and 100.
*/ */
public function getPriority() { public function getPriority(): int {
return 10; return 10;
} }

View File

@ -53,7 +53,7 @@ class ServerInfoSettingsController extends Controller {
string $providerWebsite, string $providerWebsite,
string $providerPrivacyLink, string $providerPrivacyLink,
string $adminContact string $adminContact
) { ): void {
$configs = [ $configs = [
ServerInfo::SETTING_LOCATION => $location, ServerInfo::SETTING_LOCATION => $location,
ServerInfo::SETTING_PROVIDER => $provider, ServerInfo::SETTING_PROVIDER => $provider,