small fixes

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>

settings/Application.php

@@ -96,16 +96,18 @@ class Application extends App {
 				$c->query('Logger')
 			);
 		});
+
 		$container->registerService('AppSettingsController', function(IContainer $c) {
 			return new AppSettingsController(
 				$c->query('AppName'),
 				$c->query('Request'),
 				$c->query('L10N'),
 				$c->query('Config'),
-				$c->query('ICacheFactory'),
 				$c->query('INavigationManager'),
 				$c->query('IAppManager'),
-				$c->query('OcsClient')
+				$c->query('CategoryFetcher'),
+				$c->query('AppFetcher'),
+				\OC::$server->getL10NFactory()
 			);
 		});
 		$container->registerService('AuthSettingsController', function(IContainer $c) {

settings/Controller/UsersController.php

@@ -63,7 +63,7 @@ class UsersController extends Controller {
 	private $isAdmin;
 	/** @var IUserManager */
 	private $userManager;
-	/** @var \OC\Group\Manager */
+	/** @var IGroupManager */
 	private $groupManager;
 	/** @var IConfig */
 	private $config;
@@ -671,9 +671,6 @@ class UsersController extends Controller {
 	 * @PasswordConfirmationRequired
 	 * @todo merge into saveUserSettings
 	 *
-	 * @NoAdminRequired
-	 * @PasswordConfirmationRequired
-	 *
 	 * @param string $username
 	 * @param string $displayName
 	 * @return DataResponse

settings/js/federationscopemenu.js

@@ -46,8 +46,8 @@
 			this._scopes = [
 				{
 					name: 'private',
-					displayName: (this.field == 'avatar' || this.field == 'displayname') ? t('core', 'Local') : t('core', 'Private'),
+					displayName: (this.field === 'avatar' || this.field === 'displayname') ? t('core', 'Local') : t('core', 'Private'),
-					tooltip: (this.field == 'avatar' || this.field == 'displayname') ? t('core', 'Only visible to local users') : t('core', 'Only visible to you'),
+					tooltip: (this.field === 'avatar' || this.field === 'displayname') ? t('core', 'Only visible to local users') : t('core', 'Only visible to you'),
 					icon: OC.imagePath('core', 'actions/password'),
 					active: false
 				},