mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #23499 from nextcloud/backport/23492/stable19 

[stable19] SharedMountTest.php:367 is unreliable
This commit is contained in:
Morris Jobke 2020-10-16 10:57:25 +02:00 committed by GitHub
parent 53ce5e7eeb a4530c8942
commit 5ce47c8e31
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
apps/files_sharing/tests/SharedMountTest.php
View File

@ -335,6 +335,7 @@ class SharedMountTest extends TestCase {
* @dataProvider dataPermissionMovedGroupShare * @dataProvider dataPermissionMovedGroupShare
*/ */
public function testPermissionMovedGroupShare($type, $beforePerm, $afterPerm) { public function testPermissionMovedGroupShare($type, $beforePerm, $afterPerm) {
$this->markTestSkipped('Unreliable test');
if ($type === 'file') { if ($type === 'file') {
$path = $this->filename; $path = $this->filename;
} elseif ($type === 'folder') { } elseif ($type === 'folder') {
@ -363,7 +364,7 @@ class SharedMountTest extends TestCase {
// Login as user 2 and verify the item exists // Login as user 2 and verify the item exists
self::loginHelper(self::TEST_FILES_SHARING_API_USER2); self::loginHelper(self::TEST_FILES_SHARING_API_USER2);
$this->assertTrue(\OC\Files\Filesystem::file_exists($path)); $this->assertTrue(\OC\Files\Filesystem::file_exists($path)); // TODO: unreliable - this is sometimes false
$result = $this->shareManager->getShareById($share->getFullId(), self::TEST_FILES_SHARING_API_USER2); $result = $this->shareManager->getShareById($share->getFullId(), self::TEST_FILES_SHARING_API_USER2);
$this->assertEquals($beforePerm, $result->getPermissions()); $this->assertEquals($beforePerm, $result->getPermissions());