From 4ab7f58745dd7583163f5f56804774c19b750b57 Mon Sep 17 00:00:00 2001 From: Myles McNamara Date: Fri, 28 Feb 2014 11:15:49 -0500 Subject: [PATCH 1/2] replace spaces in download link without encoding entire URL --- lib/private/app.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/private/app.php b/lib/private/app.php index 048d4d4aeb..cc3a002528 100644 --- a/lib/private/app.php +++ b/lib/private/app.php @@ -218,6 +218,8 @@ class OC_App{ }else{ $appdata=OC_OCSClient::getApplication($app); $download=OC_OCSClient::getApplicationDownload($app, 1); + // Replace spaces in download link without encoding entire URL + $download['downloadlink'] = str_replace(' ', '%20', $download['downloadlink']); if(isset($download['downloadlink']) and $download['downloadlink']!='') { $info = array('source'=>'http', 'href'=>$download['downloadlink'], 'appdata'=>$appdata); $app=OC_Installer::installApp($info); From 195bdff91fc55bf4d2c80ff7d978d74e6efac7a8 Mon Sep 17 00:00:00 2001 From: Myles McNamara Date: Fri, 28 Feb 2014 11:19:19 -0500 Subject: [PATCH 2/2] move replace to inside isset --- lib/private/app.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/private/app.php b/lib/private/app.php index cc3a002528..58bf67c1d4 100644 --- a/lib/private/app.php +++ b/lib/private/app.php @@ -218,9 +218,9 @@ class OC_App{ }else{ $appdata=OC_OCSClient::getApplication($app); $download=OC_OCSClient::getApplicationDownload($app, 1); - // Replace spaces in download link without encoding entire URL - $download['downloadlink'] = str_replace(' ', '%20', $download['downloadlink']); if(isset($download['downloadlink']) and $download['downloadlink']!='') { + // Replace spaces in download link without encoding entire URL + $download['downloadlink'] = str_replace(' ', '%20', $download['downloadlink']); $info = array('source'=>'http', 'href'=>$download['downloadlink'], 'appdata'=>$appdata); $app=OC_Installer::installApp($info); }