From 7cdb16979a6c7e75b71dd8c7c5b39b6482041fb8 Mon Sep 17 00:00:00 2001
From: Fabian Henze <flyser42@gmx.de>
Date: Thu, 3 Apr 2014 01:17:28 +0200
Subject: [PATCH 1/2] Fix setting the max-upload-size for really large values.

php can only parse filesize units up to gigabytes, not terabytes or petabytes.
---
 lib/private/files.php  |  4 +---
 lib/private/helper.php | 26 ++++++++++++++++++++++++++
 2 files changed, 27 insertions(+), 3 deletions(-)

diff --git a/lib/private/files.php b/lib/private/files.php
index bfe6d3c02d..46cb85a630 100644
--- a/lib/private/files.php
+++ b/lib/private/files.php
@@ -280,9 +280,7 @@ class OC_Files {
 				return false;
 			$size -= 1;
 		} else {
-			$size = OC_Helper::humanFileSize($size);
-			$size = substr($size, 0, -1); //strip the B
-			$size = str_replace(' ', '', $size); //remove the space between the size and the postfix
+			$size = OC_Helper::phpFileSize($size);
 		}
 
 		//don't allow user to break his config -- broken or malicious size input
diff --git a/lib/private/helper.php b/lib/private/helper.php
index d7ac0b5f4f..5cd1fbacce 100644
--- a/lib/private/helper.php
+++ b/lib/private/helper.php
@@ -305,6 +305,32 @@ class OC_Helper {
 		return "$bytes PB";
 	}
 
+	/**
+	 * @brief Make a php file size
+	 * @param int $bytes file size in bytes
+	 * @return string a php parseable file size
+	 *
+	 * Makes 2048 to 2k and 2^41 to 2048G
+	 */
+	public static function phpFileSize($bytes) {
+		if ($bytes < 0) {
+			return "?";
+		}
+		if ($bytes < 1024) {
+			return $bytes . "B";
+		}
+		$bytes = round($bytes / 1024, 1);
+		if ($bytes < 1024) {
+			return $bytes . "K";
+		}
+		$bytes = round($bytes / 1024, 1);
+		if ($bytes < 1024) {
+			return $bytes . "M";
+		}
+		$bytes = round($bytes / 1024, 1);
+		return $bytes . "G";
+	}
+
 	/**
 	 * @brief Make a computer file size
 	 * @param string $str file size in human readable format

From 1245ff8f318fafd66eed1ba8f9f2b3755aa537ca Mon Sep 17 00:00:00 2001
From: Fabian Henze <flyser42@gmx.de>
Date: Mon, 7 Apr 2014 15:31:34 +0200
Subject: [PATCH 2/2] Add unit tests for OC_Helper::phpFileSize function

---
 tests/lib/helper.php | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/tests/lib/helper.php b/tests/lib/helper.php
index 0943e6bc1b..7177570d67 100644
--- a/tests/lib/helper.php
+++ b/tests/lib/helper.php
@@ -30,6 +30,28 @@ class Test_Helper extends PHPUnit_Framework_TestCase {
 		);
 	}
 
+	/**
+	 * @dataProvider phpFileSizeProvider
+	 */
+	public function testPhpFileSize($expected, $input)
+	{
+		$result = OC_Helper::phpFileSize($input);
+		$this->assertEquals($expected, $result);
+	}
+
+	public function phpFileSizeProvider()
+	{
+		return array(
+			array('0B', 0),
+			array('1K', 1024),
+			array('9.5M', 10000000),
+			array('1.3G', 1395864371),
+			array('465.7G', 500000000000),
+			array('465661.3G', 500000000000000),
+			array('465661287.3G', 500000000000000000),
+		);
+	}
+
 	/**
 	 * @dataProvider computerFileSizeProvider
 	 */