From 014fa8c6860d1824c172da4d4ea2c56906968b28 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Julius=20H=C3=A4rtl?= Date: Sun, 18 Feb 2018 13:43:56 +0100 Subject: [PATCH] Fix hiding and event propagation issues with the user management popover MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Julius Härtl --- settings/js/users/users.js | 10 ++++++---- settings/templates/users/part.userlist.php | 2 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/settings/js/users/users.js b/settings/js/users/users.js index 5a337c3855..0b94401941 100644 --- a/settings/js/users/users.js +++ b/settings/js/users/users.js @@ -940,7 +940,7 @@ $(document).ready(function () { UserList._triggerGroupEdit($td, isSubadminSelect); }); - $userListBody.on('click', '.toggleUserActions', function (event) { + $userListBody.on('click', '.toggleUserActions > .action', function (event) { event.stopPropagation(); var $td = $(this).closest('td'); var $tr = $($td).closest('tr'); @@ -963,9 +963,11 @@ $(document).ready(function () { $tr.addClass('active'); }); - $(document).on('mouseup', function () { - $('#userlist tr.active').removeClass('active'); - $('#userlist .popovermenu.open').removeClass('open'); + $(document).on('mouseup', function (event) { + if (!$(event.target).closest('.toggleUserActions').length) { + $('#userlist tr.active').removeClass('active'); + $('#userlist .popovermenu.open').removeClass('open'); + } }); $userListBody.on('click', '.action-togglestate', function (event) { diff --git a/settings/templates/users/part.userlist.php b/settings/templates/users/part.userlist.php index aaf20b6eae..2506dba7fc 100644 --- a/settings/templates/users/part.userlist.php +++ b/settings/templates/users/part.userlist.php @@ -67,7 +67,7 @@
-