Merge pull request #8253 from owncloud/pk-on-all-tables-master

Primary keys on all tables master

apps/files_trashbin/appinfo/database.xml

@@ -13,6 +13,15 @@
 
   <declaration>
 
+	  <field>
+		  <name>auto_id</name>
+		  <type>integer</type>
+		  <default>0</default>
+		  <notnull>true</notnull>
+		  <autoincrement>1</autoincrement>
+		  <length>4</length>
+	  </field>
+
    <field>
     <name>id</name>
     <type>text</type>

apps/files_trashbin/appinfo/version

@@ -1 +1 @@
-0.6
+0.6.1

apps/user_ldap/appinfo/database.xml

@@ -46,6 +46,7 @@
 
    <index>
     <name>owncloud_name_users</name>
+	   <primary>true</primary>
     <unique>true</unique>
     <field>
      <name>owncloud_name</name>
@@ -90,6 +91,7 @@
    <index>
     <name>ldap_dn_groups</name>
     <unique>true</unique>
+	   <primary>true</primary>
     <field>
      <name>ldap_dn</name>
     </field>
@@ -132,6 +134,7 @@
    <index>
     <name>ldap_group_members_index</name>
     <unique>true</unique>
+	   <primary>true</primary>
     <field>
      <name>owncloudname</name>
     </field>
@@ -141,4 +144,4 @@
 
  </table>
 
-</database>
+</database>

lib/private/db/mdb2schemamanager.php

@@ -109,7 +109,7 @@ class MDB2SchemaManager {
 	 */
 	public function simulateUpdateDbFromStructure($file) {
 		$toSchema = $this->readSchemaFromFile($file);
-		$migrator = $this->getMigrator()->checkMigrate($toSchema);
+		$this->getMigrator()->checkMigrate($toSchema);
 		return true;
 	}
 

lib/private/updater.php

@@ -150,6 +150,7 @@ class Updater extends BasicEmitter {
 			// This is added to prevent host header poisoning
 			\OC_Config::setValue('trusted_domains', \OC_Config::getValue('trusted_domains', array(\OC_Request::serverHost())));
 		}
+
 		/*
 		 * STOP CONFIG CHANGES FOR OLDER VERSIONS
 		 */

tests/lib/db/mdb2schemamanager.php

@@ -0,0 +1,37 @@
+<?php
+
+/**
+ * Copyright (c) 2014 Thomas Müller <deepdiver@owncloud.com>
+ * This file is licensed under the Affero General Public License version 3 or
+ * later.
+ * See the COPYING-README file.
+ */
+
+namespace Test\DB;
+
+class MDB2SchemaManager extends \PHPUnit_Framework_TestCase {
+
+	public function tearDown() {
+		\OC_DB::dropTable('table');
+	}
+
+	public function testAutoIncrement() {
+
+		if (\OC::$server->getConfig()->getSystemValue('dbtype', 'sqlite') === 'oci') {
+			$this->markTestSkipped('Adding auto increment columns in Oracle is not supported.');
+		}
+
+		$connection = \OC_DB::getConnection();
+		$manager = new \OC\DB\MDB2SchemaManager($connection);
+
+		$manager->createDbFromStructure(__DIR__ . '/ts-autoincrement-before.xml');
+		$connection->executeUpdate('insert into `*PREFIX*table` values (?)', array('abc'));
+		$connection->executeUpdate('insert into `*PREFIX*table` values (?)', array('abc'));
+		$connection->executeUpdate('insert into `*PREFIX*table` values (?)', array('123'));
+		$connection->executeUpdate('insert into `*PREFIX*table` values (?)', array('123'));
+		$manager->updateDbFromStructure(__DIR__ . '/ts-autoincrement-after.xml');
+
+		$this->assertTrue(true);
+	}
+
+}

tests/lib/db/ts-autoincrement-after.xml

@@ -0,0 +1,32 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<database>
+
+	<name>*dbname*</name>
+	<create>true</create>
+	<overwrite>false</overwrite>
+
+	<charset>utf8</charset>
+
+	<table>
+
+		<name>*dbprefix*table</name>
+
+		<declaration>
+			<field>
+				<name>auto_id</name>
+				<type>integer</type>
+				<default>0</default>
+				<notnull>true</notnull>
+				<autoincrement>1</autoincrement>
+				<length>4</length>
+			</field>
+			<field>
+				<name>textfield</name>
+				<type>text</type>
+				<default>foo</default>
+				<notnull>true</notnull>
+				<length>32</length>
+			</field>
+		</declaration>
+	</table>
+</database>

tests/lib/db/ts-autoincrement-before.xml

@@ -0,0 +1,24 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<database>
+
+	<name>*dbname*</name>
+	<create>true</create>
+	<overwrite>false</overwrite>
+
+	<charset>utf8</charset>
+
+	<table>
+
+		<name>*dbprefix*table</name>
+
+		<declaration>
+			<field>
+				<name>textfield</name>
+				<type>text</type>
+				<default>foo</default>
+				<notnull>true</notnull>
+				<length>32</length>
+			</field>
+		</declaration>
+	</table>
+</database>