From 66511469e04fdf17dfc45711ad98518fab94a712 Mon Sep 17 00:00:00 2001 From: Jakob Sack Date: Thu, 9 Aug 2012 22:22:43 +0200 Subject: [PATCH] Backgroundjobs: Improve error handling in cron.php --- cron.php | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/cron.php b/cron.php index 9d7e396d61..646e37e4c1 100644 --- a/cron.php +++ b/cron.php @@ -20,11 +20,26 @@ * */ +function handleCliShutdown() { + $error = error_get_last(); + if($error !== NULL){ + echo 'Unexpected error!'.PHP_EOL; + } +} + +function handleWebShutdown(){ + $error = error_get_last(); + if($error !== NULL){ + OC_JSON::error( array( 'data' => array( 'message' => 'Unexpected error!'))); + } +} + $RUNTIME_NOSETUPFS = true; require_once('lib/base.php'); $appmode = OC_Appconfig::getValue( 'core', 'backgroundjobs_mode', 'ajax' ); if( OC::$CLI ){ + register_shutdown_function('handleCliShutdown'); if( $appmode != 'cron' ){ OC_Appconfig::setValue( 'core', 'backgroundjobs_mode', 'cron' ); } @@ -41,6 +56,7 @@ if( OC::$CLI ){ OC_BackgroundJob_Worker::doAllSteps(); } else{ + register_shutdown_function('handleWebShutdown'); if( $appmode == 'cron' ){ OC_JSON::error( array( 'data' => array( 'message' => 'Backgroundjobs are using system cron!'))); exit();