integration tests for hardening user home retrieval
This commit is contained in:
Arthur Schiwon
parent
0e922b1841
commit
6787774a32
|
|
@ -0,0 +1,159 @@
|
|||
<?php
|
||||
/**
|
||||
* Created by PhpStorm.
|
||||
* User: blizzz
|
||||
* Date: 06.08.15
|
||||
* Time: 08:19
|
||||
*/
|
||||
|
||||
namespace OCA\user_ldap\tests\integration\lib;
|
||||
|
||||
use OCA\user_ldap\lib\user\Manager as LDAPUserManager;
|
||||
use OCA\user_ldap\tests\integration\AbstractIntegrationTest;
|
||||
use OCA\User_LDAP\Mapping\UserMapping;
|
||||
use OCA\user_ldap\USER_LDAP;
|
||||
|
||||
require_once __DIR__ . '/../../../../../lib/base.php';
|
||||
|
||||
class IntegrationTestUserHome extends AbstractIntegrationTest {
|
||||
/** @var UserMapping */
|
||||
protected $mapping;
|
||||
|
||||
/** @var USER_LDAP */
|
||||
protected $backend;
|
||||
|
||||
/**
|
||||
* prepares the LDAP environment and sets up a test configuration for
|
||||
* the LDAP backend.
|
||||
*/
|
||||
public function init() {
|
||||
require(__DIR__ . '/../setup-scripts/createExplicitUsers.php');
|
||||
parent::init();
|
||||
|
||||
$this->mapping = new UserMapping(\OC::$server->getDatabaseConnection());
|
||||
$this->mapping->clear();
|
||||
$this->access->setUserMapper($this->mapping);
|
||||
$this->backend = new \OCA\user_ldap\USER_LDAP($this->access, \OC::$server->getConfig());
|
||||
}
|
||||
|
||||
/**
|
||||
* sets up the LDAP configuration to be used for the test
|
||||
*/
|
||||
protected function initConnection() {
|
||||
parent::initConnection();
|
||||
$this->connection->setConfiguration([
|
||||
'homeFolderNamingRule' => 'homeDirectory',
|
||||
]);
|
||||
}
|
||||
|
||||
/**
|
||||
* initializes an LDAP user manager instance
|
||||
* @return LDAPUserManager
|
||||
*/
|
||||
protected function initUserManager() {
|
||||
$this->userManager = new LDAPUserManager(
|
||||
\OC::$server->getConfig(),
|
||||
new \OCA\user_ldap\lib\FilesystemHelper(),
|
||||
new \OCA\user_ldap\lib\LogWrapper(),
|
||||
\OC::$server->getAvatarManager(),
|
||||
new \OCP\Image(),
|
||||
\OC::$server->getDatabaseConnection()
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* homeDirectory on LDAP is empty. Return values of getHome should be
|
||||
* identical to user name, following ownCloud default.
|
||||
*
|
||||
* @return bool
|
||||
*/
|
||||
protected function case1() {
|
||||
\OC::$server->getConfig()->setAppValue('user_ldap', 'enforce_home_folder_naming_rule', false);
|
||||
$userManager = \oc::$server->getUserManager();
|
||||
$userManager->clearBackends();
|
||||
$userManager->registerBackend($this->backend);
|
||||
$users = $userManager->search('', 5, 0);
|
||||
|
||||
foreach($users as $user) {
|
||||
$home = $user->getHome();
|
||||
$uid = $user->getUID();
|
||||
$posFound = strpos($home, '/' . $uid);
|
||||
$posExpected = strlen($home) - (strlen($uid) + 1);
|
||||
if($posFound === false || $posFound !== $posExpected) {
|
||||
print('"' . $user->getUID() . '" was not found in "' . $home . '" or does not end with it.' . PHP_EOL);
|
||||
return false;
|
||||
}
|
||||
}
|
||||
|
||||
return true;
|
||||
}
|
||||
|
||||
/**
|
||||
* homeDirectory on LDAP is empty. Having the attributes set is enforced.
|
||||
*
|
||||
* @return bool
|
||||
*/
|
||||
protected function case2() {
|
||||
\OC::$server->getConfig()->setAppValue('user_ldap', 'enforce_home_folder_naming_rule', true);
|
||||
$userManager = \oc::$server->getUserManager();
|
||||
// clearing backends is critical, otherwise the userManager will have
|
||||
// the user objects cached and the value from case1 returned
|
||||
$userManager->clearBackends();
|
||||
$userManager->registerBackend($this->backend);
|
||||
$users = $userManager->search('', 5, 0);
|
||||
|
||||
try {
|
||||
foreach ($users as $user) {
|
||||
$user->getHome();
|
||||
print('User home was retrieved without throwing an Exception!' . PHP_EOL);
|
||||
return false;
|
||||
}
|
||||
} catch (\Exception $e) {
|
||||
if(strpos($e->getMessage(), 'Home dir attribute') === 0) {
|
||||
return true;
|
||||
}
|
||||
}
|
||||
|
||||
return false;
|
||||
}
|
||||
|
||||
/**
|
||||
* homeDirectory on LDAP is set to "attr:" which is effectively empty.
|
||||
* Return values of getHome should be ownCloud default.
|
||||
*
|
||||
* @return bool
|
||||
*/
|
||||
protected function case3() {
|
||||
\OC::$server->getConfig()->setAppValue('user_ldap', 'enforce_home_folder_naming_rule', true);
|
||||
$this->connection->setConfiguration([
|
||||
'homeFolderNamingRule' => 'attr:',
|
||||
]);
|
||||
$userManager = \oc::$server->getUserManager();
|
||||
$userManager->clearBackends();
|
||||
$userManager->registerBackend($this->backend);
|
||||
$users = $userManager->search('', 5, 0);
|
||||
|
||||
try {
|
||||
foreach ($users as $user) {
|
||||
$home = $user->getHome();
|
||||
$uid = $user->getUID();
|
||||
$posFound = strpos($home, '/' . $uid);
|
||||
$posExpected = strlen($home) - (strlen($uid) + 1);
|
||||
if ($posFound === false || $posFound !== $posExpected) {
|
||||
print('"' . $user->getUID() . '" was not found in "' . $home . '" or does not end with it.' . PHP_EOL);
|
||||
return false;
|
||||
}
|
||||
}
|
||||
} catch (\Exception $e) {
|
||||
print("Unexpected Exception: " . $e->getMessage() . PHP_EOL);
|
||||
return false;
|
||||
}
|
||||
|
||||
return true;
|
||||
}
|
||||
}
|
||||
|
||||
require_once(__DIR__ . '/../setup-scripts/config.php');
|
||||
$test = new IntegrationTestUserHome($host, $port, $adn, $apwd, $bdn);
|
||||
$test->init();
|
||||
$test->run();
|
||||
Loading…
Reference in New Issue