From 68ea287ed7fc6255f583302de8cf07b3937ac32e Mon Sep 17 00:00:00 2001 From: Roeland Jago Douma Date: Fri, 26 Aug 2016 15:00:18 +0200 Subject: [PATCH] Remove the core tag routes since they are broken Private internal stuff that nobody *should* be using anyways. But on top of that already broken for a long time. So nobody could be using it even. --- core/Tags/Controller.php | 129 --------------------------------------- core/routes.php | 37 ----------- 2 files changed, 166 deletions(-) delete mode 100644 core/Tags/Controller.php diff --git a/core/Tags/Controller.php b/core/Tags/Controller.php deleted file mode 100644 index 3cba40636b..0000000000 --- a/core/Tags/Controller.php +++ /dev/null @@ -1,129 +0,0 @@ - - * @author Thomas Tanghus - * - * @license AGPL-3.0 - * - * This code is free software: you can redistribute it and/or modify - * it under the terms of the GNU Affero General Public License, version 3, - * as published by the Free Software Foundation. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU Affero General Public License for more details. - * - * You should have received a copy of the GNU Affero General Public License, version 3, - * along with this program. If not, see - * - */ - -namespace OC\Core\Tags; - -class Controller { - protected static function getTagger($type) { - \OC_JSON::checkLoggedIn(); - \OC_JSON::callCheck(); - - try { - $tagger = \OC::$server->getTagManager()->load($type); - return $tagger; - } catch(\Exception $e) { - \OCP\Util::writeLog('core', __METHOD__ . ' Exception: ' . $e->getMessage(), \OCP\Util::ERROR); - $l = new \OC_L10n('core'); - \OC_JSON::error(array('message'=> $l->t('Error loading tags'))); - exit; - } - } - - public static function getTags($args) { - $tagger = self::getTagger($args['type']); - \OC_JSON::success(array('tags'=> $tagger->getTags())); - } - - public static function getFavorites($args) { - $tagger = self::getTagger($args['type']); - \OC_JSON::success(array('ids'=> $tagger->getFavorites())); - } - - public static function getIdsForTag($args) { - $tagger = self::getTagger($args['type']); - \OC_JSON::success(array('ids'=> $tagger->getIdsForTag($_GET['tag']))); - } - - public static function addTag($args) { - $tagger = self::getTagger($args['type']); - - $id = $tagger->add(strip_tags($_POST['tag'])); - if($id === false) { - $l = new \OC_L10n('core'); - \OC_JSON::error(array('message'=> $l->t('Tag already exists'))); - } else { - \OC_JSON::success(array('id'=> $id)); - } - } - - public static function deleteTags($args) { - $tags = $_POST['tags']; - if(!is_array($tags)) { - $tags = array($tags); - } - - $tagger = self::getTagger($args['type']); - - if(!$tagger->delete($tags)) { - $l = new \OC_L10n('core'); - \OC_JSON::error(array('message'=> $l->t('Error deleting tag(s)'))); - } else { - \OC_JSON::success(); - } - } - - public static function tagAs($args) { - $tagger = self::getTagger($args['type']); - - if(!$tagger->tagAs($args['id'], $_POST['tag'])) { - $l = new \OC_L10n('core'); - \OC_JSON::error(array('message'=> $l->t('Error tagging'))); - } else { - \OC_JSON::success(); - } - } - - public static function unTag($args) { - $tagger = self::getTagger($args['type']); - - if(!$tagger->unTag($args['id'], $_POST['tag'])) { - $l = new \OC_L10n('core'); - \OC_JSON::error(array('message'=> $l->t('Error untagging'))); - } else { - \OC_JSON::success(); - } - } - - public static function favorite($args) { - $tagger = self::getTagger($args['type']); - - if(!$tagger->addToFavorites($args['id'])) { - $l = new \OC_L10n('core'); - \OC_JSON::error(array('message'=> $l->t('Error favoriting'))); - } else { - \OC_JSON::success(); - } - } - - public static function unFavorite($args) { - $tagger = self::getTagger($args['type']); - - if(!$tagger->removeFromFavorites($args['id'])) { - $l = new \OC_L10n('core'); - \OC_JSON::error(array('message'=> $l->t('Error unfavoriting'))); - } else { - \OC_JSON::success(); - } - } - -} diff --git a/core/routes.php b/core/routes.php index dde7124593..b04b0db4ce 100644 --- a/core/routes.php +++ b/core/routes.php @@ -70,43 +70,6 @@ $this->create('search_ajax_search', '/core/search') // AppConfig $this->create('core_ajax_appconfig', '/core/ajax/appconfig.php') ->actionInclude('core/ajax/appconfig.php'); -// Tags -$this->create('core_tags_tags', '/tags/{type}') - ->get() - ->action('OC\Core\Tags\Controller', 'getTags') - ->requirements(array('type')); -$this->create('core_tags_favorites', '/tags/{type}/favorites') - ->get() - ->action('OC\Core\Tags\Controller', 'getFavorites') - ->requirements(array('type')); -$this->create('core_tags_ids_for_tag', '/tags/{type}/ids') - ->get() - ->action('OC\Core\Tags\Controller', 'getIdsForTag') - ->requirements(array('type')); -$this->create('core_tags_favorite', '/tags/{type}/favorite/{id}/') - ->post() - ->action('OC\Core\Tags\Controller', 'favorite') - ->requirements(array('type', 'id')); -$this->create('core_tags_unfavorite', '/tags/{type}/unfavorite/{id}/') - ->post() - ->action('OC\Core\Tags\Controller', 'unFavorite') - ->requirements(array('type', 'id')); -$this->create('core_tags_tag', '/tags/{type}/tag/{id}/') - ->post() - ->action('OC\Core\Tags\Controller', 'tagAs') - ->requirements(array('type', 'id')); -$this->create('core_tags_untag', '/tags/{type}/untag/{id}/') - ->post() - ->action('OC\Core\Tags\Controller', 'unTag') - ->requirements(array('type', 'id')); -$this->create('core_tags_add', '/tags/{type}/add') - ->post() - ->action('OC\Core\Tags\Controller', 'addTag') - ->requirements(array('type')); -$this->create('core_tags_delete', '/tags/{type}/delete') - ->post() - ->action('OC\Core\Tags\Controller', 'deleteTags') - ->requirements(array('type')); // oC JS config $this->create('js_config', '/core/js/oc.js') ->actionInclude('core/js/config.php');