From 69b26c73f3af0b72e17a3d764d45fdee91ce3a24 Mon Sep 17 00:00:00 2001 From: Roeland Jago Douma Date: Mon, 8 Mar 2021 08:51:08 +0100 Subject: [PATCH] Fix some redundant casts Happier psalm Signed-off-by: Roeland Jago Douma --- apps/federatedfilesharing/lib/FederatedShareProvider.php | 4 +--- apps/sharebymail/lib/ShareByMailProvider.php | 4 +--- lib/public/AppFramework/Db/QBMapper.php | 2 +- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/apps/federatedfilesharing/lib/FederatedShareProvider.php b/apps/federatedfilesharing/lib/FederatedShareProvider.php index fe814284fb..cd0ad49b6a 100644 --- a/apps/federatedfilesharing/lib/FederatedShareProvider.php +++ b/apps/federatedfilesharing/lib/FederatedShareProvider.php @@ -393,9 +393,7 @@ class FederatedShareProvider implements IShareProvider { $qb->setValue('file_target', $qb->createNamedParameter('')); $qb->execute(); - $id = $qb->getLastInsertId(); - - return (int)$id; + return $qb->getLastInsertId(); } /** diff --git a/apps/sharebymail/lib/ShareByMailProvider.php b/apps/sharebymail/lib/ShareByMailProvider.php index 03e46c8e02..2484ccdd72 100644 --- a/apps/sharebymail/lib/ShareByMailProvider.php +++ b/apps/sharebymail/lib/ShareByMailProvider.php @@ -690,9 +690,7 @@ class ShareByMailProvider implements IShareProvider { $qb->setValue('file_target', $qb->createNamedParameter('')); $qb->execute(); - $id = $qb->getLastInsertId(); - - return (int)$id; + return $qb->getLastInsertId(); } /** diff --git a/lib/public/AppFramework/Db/QBMapper.php b/lib/public/AppFramework/Db/QBMapper.php index 72373ba26c..8c324d9c60 100644 --- a/lib/public/AppFramework/Db/QBMapper.php +++ b/lib/public/AppFramework/Db/QBMapper.php @@ -136,7 +136,7 @@ abstract class QBMapper { if ($entity->id === null) { // When autoincrement is used id is always an int - $entity->setId((int)$qb->getLastInsertId()); + $entity->setId($qb->getLastInsertId()); } return $entity;