Merge pull request #15464 from owncloud/fixmasterunittests
Replace originalStorage in tests with a proper teardown
This commit is contained in:
commit
69ba67ec0f
|
@ -38,21 +38,15 @@ class Test_OC_Files_App_Rename extends \Test\TestCase {
|
||||||
*/
|
*/
|
||||||
private $files;
|
private $files;
|
||||||
|
|
||||||
private $originalStorage;
|
|
||||||
|
|
||||||
protected function setUp() {
|
protected function setUp() {
|
||||||
parent::setUp();
|
parent::setUp();
|
||||||
|
|
||||||
$this->originalStorage = \OC\Files\Filesystem::getStorage('/');
|
|
||||||
|
|
||||||
// mock OC_L10n
|
// mock OC_L10n
|
||||||
if (!self::$user) {
|
if (!self::$user) {
|
||||||
self::$user = uniqid();
|
self::$user = uniqid();
|
||||||
}
|
}
|
||||||
\OC_User::createUser(self::$user, 'password');
|
\OC_User::createUser(self::$user, 'password');
|
||||||
\OC_User::setUserId(self::$user);
|
$this->loginAsUser(self::$user);
|
||||||
|
|
||||||
\OC\Files\Filesystem::init(self::$user, '/' . self::$user . '/files');
|
|
||||||
|
|
||||||
$l10nMock = $this->getMock('\OC_L10N', array('t'), array(), '', false);
|
$l10nMock = $this->getMock('\OC_L10N', array('t'), array(), '', false);
|
||||||
$l10nMock->expects($this->any())
|
$l10nMock->expects($this->any())
|
||||||
|
@ -72,9 +66,8 @@ class Test_OC_Files_App_Rename extends \Test\TestCase {
|
||||||
protected function tearDown() {
|
protected function tearDown() {
|
||||||
$result = \OC_User::deleteUser(self::$user);
|
$result = \OC_User::deleteUser(self::$user);
|
||||||
$this->assertTrue($result);
|
$this->assertTrue($result);
|
||||||
\OC\Files\Filesystem::tearDown();
|
|
||||||
\OC\Files\Filesystem::mount($this->originalStorage, array(), '/');
|
|
||||||
|
|
||||||
|
$this->logout();
|
||||||
parent::tearDown();
|
parent::tearDown();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -34,11 +34,6 @@ class Storage extends \Test\TestCase {
|
||||||
*/
|
*/
|
||||||
private $user;
|
private $user;
|
||||||
|
|
||||||
/**
|
|
||||||
* @var \OC\Files\Storage\Storage
|
|
||||||
**/
|
|
||||||
private $originalStorage;
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* @var \OC\Files\View
|
* @var \OC\Files\View
|
||||||
*/
|
*/
|
||||||
|
@ -61,8 +56,6 @@ class Storage extends \Test\TestCase {
|
||||||
// this will setup the FS
|
// this will setup the FS
|
||||||
$this->loginAsUser($this->user);
|
$this->loginAsUser($this->user);
|
||||||
|
|
||||||
$this->originalStorage = \OC\Files\Filesystem::getStorage('/');
|
|
||||||
|
|
||||||
\OCA\Files_Trashbin\Storage::setupStorage();
|
\OCA\Files_Trashbin\Storage::setupStorage();
|
||||||
|
|
||||||
$this->rootView = new \OC\Files\View('/');
|
$this->rootView = new \OC\Files\View('/');
|
||||||
|
@ -73,7 +66,6 @@ class Storage extends \Test\TestCase {
|
||||||
|
|
||||||
protected function tearDown() {
|
protected function tearDown() {
|
||||||
\OC\Files\Filesystem::getLoader()->removeStorageWrapper('oc_trashbin');
|
\OC\Files\Filesystem::getLoader()->removeStorageWrapper('oc_trashbin');
|
||||||
\OC\Files\Filesystem::mount($this->originalStorage, array(), '/');
|
|
||||||
$this->logout();
|
$this->logout();
|
||||||
\OC_User::deleteUser($this->user);
|
\OC_User::deleteUser($this->user);
|
||||||
\OC_Hook::clear();
|
\OC_Hook::clear();
|
||||||
|
|
|
@ -33,16 +33,12 @@ class Updater extends \Test\TestCase {
|
||||||
*/
|
*/
|
||||||
protected $updater;
|
protected $updater;
|
||||||
|
|
||||||
/** @var \OC\Files\Storage\Storage */
|
|
||||||
private $originalStorage;
|
|
||||||
|
|
||||||
protected function setUp() {
|
protected function setUp() {
|
||||||
parent::setUp();
|
parent::setUp();
|
||||||
|
|
||||||
$this->originalStorage = Filesystem::getStorage('/');
|
$this->loginAsUser();
|
||||||
|
|
||||||
$this->storage = new Temporary(array());
|
$this->storage = new Temporary(array());
|
||||||
Filesystem::clearMounts();
|
|
||||||
Filesystem::mount($this->storage, array(), '/');
|
Filesystem::mount($this->storage, array(), '/');
|
||||||
$this->view = new View('');
|
$this->view = new View('');
|
||||||
$this->updater = new \OC\Files\Cache\Updater($this->view);
|
$this->updater = new \OC\Files\Cache\Updater($this->view);
|
||||||
|
@ -51,8 +47,8 @@ class Updater extends \Test\TestCase {
|
||||||
|
|
||||||
protected function tearDown() {
|
protected function tearDown() {
|
||||||
Filesystem::clearMounts();
|
Filesystem::clearMounts();
|
||||||
Filesystem::mount($this->originalStorage, array(), '/');
|
|
||||||
|
|
||||||
|
$this->logout();
|
||||||
parent::tearDown();
|
parent::tearDown();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -27,9 +27,6 @@ class UpdaterLegacy extends \Test\TestCase {
|
||||||
*/
|
*/
|
||||||
private $cache;
|
private $cache;
|
||||||
|
|
||||||
/** @var \OC\Files\Storage\Storage */
|
|
||||||
private $originalStorage;
|
|
||||||
|
|
||||||
private static $user;
|
private static $user;
|
||||||
|
|
||||||
protected function setUp() {
|
protected function setUp() {
|
||||||
|
@ -48,14 +45,12 @@ class UpdaterLegacy extends \Test\TestCase {
|
||||||
$this->scanner->scan('');
|
$this->scanner->scan('');
|
||||||
$this->cache = $this->storage->getCache();
|
$this->cache = $this->storage->getCache();
|
||||||
|
|
||||||
$this->originalStorage = Filesystem::getStorage('/');
|
|
||||||
Filesystem::tearDown();
|
|
||||||
if (!self::$user) {
|
if (!self::$user) {
|
||||||
self::$user = $this->getUniqueID();
|
self::$user = $this->getUniqueID();
|
||||||
}
|
}
|
||||||
|
|
||||||
\OC_User::createUser(self::$user, 'password');
|
\OC_User::createUser(self::$user, 'password');
|
||||||
\OC_User::setUserId(self::$user);
|
$this->loginAsUser(self::$user);
|
||||||
|
|
||||||
Filesystem::init(self::$user, '/' . self::$user . '/files');
|
Filesystem::init(self::$user, '/' . self::$user . '/files');
|
||||||
|
|
||||||
|
@ -71,9 +66,8 @@ class UpdaterLegacy extends \Test\TestCase {
|
||||||
}
|
}
|
||||||
$result = \OC_User::deleteUser(self::$user);
|
$result = \OC_User::deleteUser(self::$user);
|
||||||
$this->assertTrue($result);
|
$this->assertTrue($result);
|
||||||
Filesystem::tearDown();
|
|
||||||
Filesystem::mount($this->originalStorage, array(), '/');
|
|
||||||
|
|
||||||
|
$this->logout();
|
||||||
parent::tearDown();
|
parent::tearDown();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -15,14 +15,10 @@ class Watcher extends \Test\TestCase {
|
||||||
*/
|
*/
|
||||||
private $storages = array();
|
private $storages = array();
|
||||||
|
|
||||||
/** @var \OC\Files\Storage\Storage */
|
|
||||||
private $originalStorage;
|
|
||||||
|
|
||||||
protected function setUp() {
|
protected function setUp() {
|
||||||
parent::setUp();
|
parent::setUp();
|
||||||
|
|
||||||
$this->originalStorage = \OC\Files\Filesystem::getStorage('/');
|
$this->loginAsUser();
|
||||||
\OC\Files\Filesystem::clearMounts();
|
|
||||||
}
|
}
|
||||||
|
|
||||||
protected function tearDown() {
|
protected function tearDown() {
|
||||||
|
@ -32,9 +28,7 @@ class Watcher extends \Test\TestCase {
|
||||||
$cache->clear();
|
$cache->clear();
|
||||||
}
|
}
|
||||||
|
|
||||||
\OC\Files\Filesystem::clearMounts();
|
$this->logout();
|
||||||
\OC\Files\Filesystem::mount($this->originalStorage, array(), '/');
|
|
||||||
|
|
||||||
parent::tearDown();
|
parent::tearDown();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -16,16 +16,11 @@ class EtagTest extends \Test\TestCase {
|
||||||
|
|
||||||
private $tmpDir;
|
private $tmpDir;
|
||||||
|
|
||||||
private $uid;
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* @var \OC_User_Dummy $userBackend
|
* @var \OC_User_Dummy $userBackend
|
||||||
*/
|
*/
|
||||||
private $userBackend;
|
private $userBackend;
|
||||||
|
|
||||||
/** @var \OC\Files\Storage\Storage */
|
|
||||||
private $originalStorage;
|
|
||||||
|
|
||||||
protected function setUp() {
|
protected function setUp() {
|
||||||
parent::setUp();
|
parent::setUp();
|
||||||
|
|
||||||
|
@ -37,21 +32,15 @@ class EtagTest extends \Test\TestCase {
|
||||||
$this->datadir = \OC_Config::getValue('datadirectory');
|
$this->datadir = \OC_Config::getValue('datadirectory');
|
||||||
$this->tmpDir = \OC_Helper::tmpFolder();
|
$this->tmpDir = \OC_Helper::tmpFolder();
|
||||||
\OC_Config::setValue('datadirectory', $this->tmpDir);
|
\OC_Config::setValue('datadirectory', $this->tmpDir);
|
||||||
$this->uid = \OC_User::getUser();
|
|
||||||
\OC_User::setUserId(null);
|
|
||||||
|
|
||||||
$this->userBackend = new \OC_User_Dummy();
|
$this->userBackend = new \OC_User_Dummy();
|
||||||
\OC_User::useBackend($this->userBackend);
|
\OC_User::useBackend($this->userBackend);
|
||||||
$this->originalStorage = \OC\Files\Filesystem::getStorage('/');
|
|
||||||
\OC_Util::tearDownFS();
|
|
||||||
}
|
}
|
||||||
|
|
||||||
protected function tearDown() {
|
protected function tearDown() {
|
||||||
\OC_Config::setValue('datadirectory', $this->datadir);
|
\OC_Config::setValue('datadirectory', $this->datadir);
|
||||||
\OC_User::setUserId($this->uid);
|
|
||||||
\OC_Util::setupFS($this->uid);
|
|
||||||
\OC\Files\Filesystem::mount($this->originalStorage, array(), '/');
|
|
||||||
|
|
||||||
|
$this->logout();
|
||||||
parent::tearDown();
|
parent::tearDown();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -59,9 +48,7 @@ class EtagTest extends \Test\TestCase {
|
||||||
$user1 = $this->getUniqueID('user_');
|
$user1 = $this->getUniqueID('user_');
|
||||||
$this->userBackend->createUser($user1, '');
|
$this->userBackend->createUser($user1, '');
|
||||||
|
|
||||||
\OC_Util::tearDownFS();
|
$this->loginAsUser($user1);
|
||||||
\OC_User::setUserId($user1);
|
|
||||||
\OC_Util::setupFS($user1);
|
|
||||||
Filesystem::mkdir('/folder');
|
Filesystem::mkdir('/folder');
|
||||||
Filesystem::mkdir('/folder/subfolder');
|
Filesystem::mkdir('/folder/subfolder');
|
||||||
Filesystem::file_put_contents('/foo.txt', 'asd');
|
Filesystem::file_put_contents('/foo.txt', 'asd');
|
||||||
|
|
|
@ -28,9 +28,6 @@ class Filesystem extends \Test\TestCase {
|
||||||
*/
|
*/
|
||||||
private $tmpDirs = array();
|
private $tmpDirs = array();
|
||||||
|
|
||||||
/** @var \OC\Files\Storage\Storage */
|
|
||||||
private $originalStorage;
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* @return array
|
* @return array
|
||||||
*/
|
*/
|
||||||
|
@ -42,20 +39,15 @@ class Filesystem extends \Test\TestCase {
|
||||||
|
|
||||||
protected function setUp() {
|
protected function setUp() {
|
||||||
parent::setUp();
|
parent::setUp();
|
||||||
|
$this->loginAsUser();
|
||||||
$this->originalStorage = \OC\Files\Filesystem::getStorage('/');
|
|
||||||
\OC_User::setUserId('');
|
|
||||||
\OC\Files\Filesystem::clearMounts();
|
|
||||||
}
|
}
|
||||||
|
|
||||||
protected function tearDown() {
|
protected function tearDown() {
|
||||||
foreach ($this->tmpDirs as $dir) {
|
foreach ($this->tmpDirs as $dir) {
|
||||||
\OC_Helper::rmdirr($dir);
|
\OC_Helper::rmdirr($dir);
|
||||||
}
|
}
|
||||||
\OC\Files\Filesystem::clearMounts();
|
|
||||||
\OC\Files\Filesystem::mount($this->originalStorage, array(), '/');
|
|
||||||
\OC_User::setUserId('');
|
|
||||||
|
|
||||||
|
$this->logout();
|
||||||
parent::tearDown();
|
parent::tearDown();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -20,9 +20,6 @@ class IntegrationTests extends \Test\TestCase {
|
||||||
*/
|
*/
|
||||||
private $root;
|
private $root;
|
||||||
|
|
||||||
/** @var \OC\Files\Storage\Storage */
|
|
||||||
private $originalStorage;
|
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* @var \OC\Files\Storage\Storage[]
|
* @var \OC\Files\Storage\Storage[]
|
||||||
*/
|
*/
|
||||||
|
@ -36,9 +33,6 @@ class IntegrationTests extends \Test\TestCase {
|
||||||
protected function setUp() {
|
protected function setUp() {
|
||||||
parent::setUp();
|
parent::setUp();
|
||||||
|
|
||||||
$this->originalStorage = \OC\Files\Filesystem::getStorage('/');
|
|
||||||
\OC\Files\Filesystem::init('', '');
|
|
||||||
\OC\Files\Filesystem::clearMounts();
|
|
||||||
$manager = \OC\Files\Filesystem::getMountManager();
|
$manager = \OC\Files\Filesystem::getMountManager();
|
||||||
|
|
||||||
\OC_Hook::clear('OC_Filesystem');
|
\OC_Hook::clear('OC_Filesystem');
|
||||||
|
@ -49,7 +43,8 @@ class IntegrationTests extends \Test\TestCase {
|
||||||
\OC_Hook::connect('OC_Filesystem', 'post_touch', '\OC\Files\Cache\Updater', 'touchHook');
|
\OC_Hook::connect('OC_Filesystem', 'post_touch', '\OC\Files\Cache\Updater', 'touchHook');
|
||||||
|
|
||||||
$user = new User($this->getUniqueID('user'), new \OC_User_Dummy);
|
$user = new User($this->getUniqueID('user'), new \OC_User_Dummy);
|
||||||
\OC_User::setUserId($user->getUID());
|
$this->loginAsUser($user->getUID());
|
||||||
|
|
||||||
$this->view = new View();
|
$this->view = new View();
|
||||||
$this->root = new Root($manager, $this->view, $user);
|
$this->root = new Root($manager, $this->view, $user);
|
||||||
$storage = new Temporary(array());
|
$storage = new Temporary(array());
|
||||||
|
@ -64,9 +59,8 @@ class IntegrationTests extends \Test\TestCase {
|
||||||
foreach ($this->storages as $storage) {
|
foreach ($this->storages as $storage) {
|
||||||
$storage->getCache()->clear();
|
$storage->getCache()->clear();
|
||||||
}
|
}
|
||||||
\OC\Files\Filesystem::clearMounts();
|
|
||||||
\OC\Files\Filesystem::mount($this->originalStorage, array(), '/');
|
|
||||||
|
|
||||||
|
$this->logout();
|
||||||
parent::tearDown();
|
parent::tearDown();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -39,18 +39,14 @@ class TestScanner extends \OC\Files\Utils\Scanner {
|
||||||
}
|
}
|
||||||
|
|
||||||
class Scanner extends \Test\TestCase {
|
class Scanner extends \Test\TestCase {
|
||||||
/** @var \OC\Files\Storage\Storage */
|
|
||||||
private $originalStorage;
|
|
||||||
|
|
||||||
protected function setUp() {
|
protected function setUp() {
|
||||||
parent::setUp();
|
parent::setUp();
|
||||||
|
|
||||||
$this->originalStorage = \OC\Files\Filesystem::getStorage('/');
|
$this->loginAsUser();
|
||||||
}
|
}
|
||||||
|
|
||||||
protected function tearDown() {
|
protected function tearDown() {
|
||||||
\OC\Files\Filesystem::mount($this->originalStorage, array(), '/');
|
$this->logout();
|
||||||
|
|
||||||
parent::tearDown();
|
parent::tearDown();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -27,9 +27,6 @@ class View extends \Test\TestCase {
|
||||||
/** @var \OC\Files\Storage\Storage */
|
/** @var \OC\Files\Storage\Storage */
|
||||||
private $tempStorage;
|
private $tempStorage;
|
||||||
|
|
||||||
/** @var \OC\Files\Storage\Storage */
|
|
||||||
private $originalStorage;
|
|
||||||
|
|
||||||
protected function setUp() {
|
protected function setUp() {
|
||||||
parent::setUp();
|
parent::setUp();
|
||||||
|
|
||||||
|
@ -39,9 +36,10 @@ class View extends \Test\TestCase {
|
||||||
//login
|
//login
|
||||||
\OC_User::createUser('test', 'test');
|
\OC_User::createUser('test', 'test');
|
||||||
$this->user = \OC_User::getUser();
|
$this->user = \OC_User::getUser();
|
||||||
\OC_User::setUserId('test');
|
|
||||||
|
|
||||||
$this->originalStorage = \OC\Files\Filesystem::getStorage('/');
|
$this->loginAsUser('test');
|
||||||
|
// clear mounts but somehow keep the root storage
|
||||||
|
// that was initialized above...
|
||||||
\OC\Files\Filesystem::clearMounts();
|
\OC\Files\Filesystem::clearMounts();
|
||||||
|
|
||||||
$this->tempStorage = null;
|
$this->tempStorage = null;
|
||||||
|
@ -59,9 +57,7 @@ class View extends \Test\TestCase {
|
||||||
system('rm -rf ' . escapeshellarg($this->tempStorage->getDataDir()));
|
system('rm -rf ' . escapeshellarg($this->tempStorage->getDataDir()));
|
||||||
}
|
}
|
||||||
|
|
||||||
\OC\Files\Filesystem::clearMounts();
|
$this->logout();
|
||||||
\OC\Files\Filesystem::mount($this->originalStorage, array(), '/');
|
|
||||||
|
|
||||||
parent::tearDown();
|
parent::tearDown();
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -26,6 +26,8 @@ class Preview extends TestCase {
|
||||||
protected function setUp() {
|
protected function setUp() {
|
||||||
parent::setUp();
|
parent::setUp();
|
||||||
|
|
||||||
|
// FIXME: use proper tearDown with $this->loginAsUser() and $this->logout()
|
||||||
|
// (would currently break the tests for some reason)
|
||||||
$this->originalStorage = \OC\Files\Filesystem::getStorage('/');
|
$this->originalStorage = \OC\Files\Filesystem::getStorage('/');
|
||||||
|
|
||||||
// create a new user with his own filesystem view
|
// create a new user with his own filesystem view
|
||||||
|
|
|
@ -72,6 +72,8 @@ class Test_StreamWrappers extends \Test\TestCase {
|
||||||
}
|
}
|
||||||
|
|
||||||
public function testOC() {
|
public function testOC() {
|
||||||
|
// FIXME: use proper tearDown with $this->loginAsUser() and $this->logout()
|
||||||
|
// (would currently break the tests for some reason)
|
||||||
$originalStorage = \OC\Files\Filesystem::getStorage('/');
|
$originalStorage = \OC\Files\Filesystem::getStorage('/');
|
||||||
\OC\Files\Filesystem::clearMounts();
|
\OC\Files\Filesystem::clearMounts();
|
||||||
|
|
||||||
|
|
|
@ -167,9 +167,9 @@ abstract class TestCase extends \PHPUnit_Framework_TestCase {
|
||||||
* Login and setup FS as a given user,
|
* Login and setup FS as a given user,
|
||||||
* sets the given user as the current user.
|
* sets the given user as the current user.
|
||||||
*
|
*
|
||||||
* @param string $user user id
|
* @param string $user user id or empty for a generic FS
|
||||||
*/
|
*/
|
||||||
static protected function loginAsUser($user) {
|
static protected function loginAsUser($user = '') {
|
||||||
self::logout();
|
self::logout();
|
||||||
\OC\Files\Filesystem::tearDown();
|
\OC\Files\Filesystem::tearDown();
|
||||||
\OC_User::setUserId($user);
|
\OC_User::setUserId($user);
|
||||||
|
|
Loading…
Reference in New Issue