Merge pull request #4611 from nextcloud/js-use-dot-notation

Use dot notation for array access - JSLint recommendation

core/js/files/client.js

@@ -725,7 +725,7 @@
 			};
 
 			if (!allowOverwrite) {
-				headers['Overwrite'] = 'F';
+				headers.Overwrite = 'F';
 			}
 
 			this._client.request(

core/js/files/iedavclient.js

@@ -32,7 +32,7 @@
 			headers = headers || {};
 
 			if (this.userName) {
-				headers['Authorization'] = 'Basic ' + btoa(this.userName + ':' + this.password);
+				headers.Authorization = 'Basic ' + btoa(this.userName + ':' + this.password);
 				// xhr.open(method, this.resolveUrl(url), true, this.userName, this.password);
 			}
 			xhr.open(method, this.resolveUrl(url), true);

core/js/js.js

@@ -2366,10 +2366,10 @@ jQuery.fn.tipsy = function(argument) {
 			options.trigger = argument.trigger;
 		}
 		if(argument.delayIn) {
-			options.delay["show"] = argument.delayIn;
+			options.delay.show = argument.delayIn;
 		}
 		if(argument.delayOut) {
-			options.delay["hide"] = argument.delayOut;
+			options.delay.hide = argument.delayOut;
 		}
 		if(argument.html) {
 			options.html = true;

core/js/lostpassword.js

@@ -22,8 +22,8 @@ OC.Lostpassword = {
 		if (!$('#user').val().length){
 			$('#submit').trigger('click');
 		} else {
-			if (OC.config['lost_password_link']) {
-				window.location = OC.config['lost_password_link'];
+			if (OC.config.lost_password_link) {
+				window.location = OC.config.lost_password_link;
 			} else {
 				$.post(
 					OC.generateUrl('/lostpassword/email'),

core/js/public/appconfig.js

@@ -79,7 +79,7 @@ OCP.AppConfig = {
 	 */
 	getValue: function(app, key, defaultValue, options) {
 		options = options || {};
-		options['data'] = {
+		options.data = {
 			defaultValue: defaultValue
 		};
 
@@ -97,7 +97,7 @@ OCP.AppConfig = {
 	 */
 	setValue: function(app, key, value, options) {
 		options = options || {};
-		options['data'] = {
+		options.data = {
 			value: value
 		};
 

core/js/share.js

@@ -192,7 +192,7 @@ OC.Share = _.extend(OC.Share || {}, {
 		}
 		if (shares) {
 			OC.Share.statuses[itemSource] = OC.Share.statuses[itemSource] || {};
-			OC.Share.statuses[itemSource]['link'] = link;
+			OC.Share.statuses[itemSource].link = link;
 		} else {
 			delete OC.Share.statuses[itemSource];
 		}