Added unit tests for setupServerSide(), key paths, and ready()
Started using Mockery library for mimicking objects
This commit is contained in:
parent
b5c0e4042e
commit
6df35eeddc
|
@ -6,10 +6,23 @@
|
||||||
* See the COPYING-README file.
|
* See the COPYING-README file.
|
||||||
*/
|
*/
|
||||||
|
|
||||||
namespace OCA\Encryption;
|
|
||||||
|
|
||||||
require_once "PHPUnit/Framework/TestCase.php";
|
require_once "PHPUnit/Framework/TestCase.php";
|
||||||
require_once realpath( dirname(__FILE__).'/../../../lib/base.php' );
|
require_once realpath( dirname(__FILE__).'/../../../lib/base.php' );
|
||||||
|
require_once realpath( dirname(__FILE__).'/../../../3rdparty/mockery/Mockery.php' );
|
||||||
|
require_once realpath( dirname(__FILE__).'/../../../3rdparty/mockery/Mockery/Container.php' );
|
||||||
|
require_once realpath( dirname(__FILE__).'/../../../3rdparty/mockery/Mockery/Generator.php' );
|
||||||
|
require_once realpath( dirname(__FILE__).'/../../../3rdparty/mockery/Mockery/MockInterface.php' );
|
||||||
|
require_once realpath( dirname(__FILE__).'/../../../3rdparty/mockery/Mockery/Configuration.php' );
|
||||||
|
require_once realpath( dirname(__FILE__).'/../../../3rdparty/mockery/Mockery/CompositeExpectation.php' );
|
||||||
|
require_once realpath( dirname(__FILE__).'/../../../3rdparty/mockery/Mockery/ExpectationDirector.php' );
|
||||||
|
require_once realpath( dirname(__FILE__).'/../../../3rdparty/mockery/Mockery/Expectation.php' );
|
||||||
|
require_once realpath( dirname(__FILE__).'/../../../3rdparty/mockery/Mockery/Exception.php' );
|
||||||
|
require_once realpath( dirname(__FILE__).'/../../../3rdparty/mockery/Mockery/CountValidator/CountValidatorAbstract.php' );
|
||||||
|
require_once realpath( dirname(__FILE__).'/../../../3rdparty/mockery/Mockery/CountValidator/Exception.php' );
|
||||||
|
require_once realpath( dirname(__FILE__).'/../../../3rdparty/mockery/Mockery/CountValidator/Exact.php' );
|
||||||
|
|
||||||
|
use \Mockery as m;
|
||||||
|
use OCA\Encryption;
|
||||||
|
|
||||||
class Test_Util extends \PHPUnit_Framework_TestCase {
|
class Test_Util extends \PHPUnit_Framework_TestCase {
|
||||||
|
|
||||||
|
@ -20,11 +33,109 @@ class Test_Util extends \PHPUnit_Framework_TestCase {
|
||||||
$this->legacyData = realpath( dirname(__FILE__).'/legacy-text.txt' );
|
$this->legacyData = realpath( dirname(__FILE__).'/legacy-text.txt' );
|
||||||
$this->legacyEncryptedData = realpath( dirname(__FILE__).'/legacy-encrypted-text.txt' );
|
$this->legacyEncryptedData = realpath( dirname(__FILE__).'/legacy-encrypted-text.txt' );
|
||||||
|
|
||||||
|
$this->userId = 'admin';
|
||||||
|
$this->pass = 'admin';
|
||||||
|
$this->publicKeyDir = '/' . 'public-keys';
|
||||||
|
$this->encryptionDir = '/' . $this->userId . '/' . 'files_encryption';
|
||||||
|
$this->keyfilesPath = $this->encryptionDir . '/' . 'keyfiles';
|
||||||
|
$this->publicKeyPath = $this->publicKeyDir . '/' . $this->userId . '.public.key'; // e.g. data/public-keys/admin.public.key
|
||||||
|
$this->privateKeyPath = $this->encryptionDir . '/' . $this->userId . '.private.key'; // e.g. data/admin/admin.private.key
|
||||||
|
|
||||||
$this->view = new OC_FilesystemView( '/admin' );
|
$this->view = new OC_FilesystemView( '/admin' );
|
||||||
|
|
||||||
}
|
}
|
||||||
|
|
||||||
function tearDown(){}
|
function tearDown(){
|
||||||
|
|
||||||
|
m::close();
|
||||||
|
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @brief test that paths set during User construction are correct
|
||||||
|
*/
|
||||||
|
function testKeyPaths() {
|
||||||
|
|
||||||
|
$mockView = m::mock('OC_FilesystemView');
|
||||||
|
|
||||||
|
$util = new Encryption\Util( $mockView, $this->userId );
|
||||||
|
|
||||||
|
$this->assertEquals( $this->publicKeyDir, $util->getPath( 'publicKeyDir' ) );
|
||||||
|
$this->assertEquals( $this->encryptionDir, $util->getPath( 'encryptionDir' ) );
|
||||||
|
$this->assertEquals( $this->keyfilesPath, $util->getPath( 'keyfilesPath' ) );
|
||||||
|
$this->assertEquals( $this->publicKeyPath, $util->getPath( 'publicKeyPath' ) );
|
||||||
|
$this->assertEquals( $this->privateKeyPath, $util->getPath( 'privateKeyPath' ) );
|
||||||
|
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @brief test setup of encryption directories when they don't yet exist
|
||||||
|
*/
|
||||||
|
function testSetupServerSideNotSetup() {
|
||||||
|
|
||||||
|
$mockView = m::mock('OC_FilesystemView');
|
||||||
|
|
||||||
|
$mockView->shouldReceive( 'file_exists' )->times(4)->andReturn( false );
|
||||||
|
$mockView->shouldReceive( 'mkdir' )->times(3)->andReturn( true );
|
||||||
|
$mockView->shouldReceive( 'file_put_contents' )->withAnyArgs();
|
||||||
|
|
||||||
|
$util = new Encryption\Util( $mockView, $this->userId );
|
||||||
|
|
||||||
|
$this->assertEquals( true, $util->setupServerSide( $this->pass ) );
|
||||||
|
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @brief test setup of encryption directories when they already exist
|
||||||
|
*/
|
||||||
|
function testSetupServerSideIsSetup() {
|
||||||
|
|
||||||
|
$mockView = m::mock('OC_FilesystemView');
|
||||||
|
|
||||||
|
$mockView->shouldReceive( 'file_exists' )->times(5)->andReturn( true );
|
||||||
|
$mockView->shouldReceive( 'file_put_contents' )->withAnyArgs();
|
||||||
|
|
||||||
|
$util = new Encryption\Util( $mockView, $this->userId );
|
||||||
|
|
||||||
|
$this->assertEquals( true, $util->setupServerSide( $this->pass ) );
|
||||||
|
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @brief test checking whether account is ready for encryption, when it isn't ready
|
||||||
|
*/
|
||||||
|
function testReadyNotReady() {
|
||||||
|
|
||||||
|
$mockView = m::mock('OC_FilesystemView');
|
||||||
|
|
||||||
|
$mockView->shouldReceive( 'file_exists' )->times(1)->andReturn( false );
|
||||||
|
|
||||||
|
$util = new Encryption\Util( $mockView, $this->userId );
|
||||||
|
|
||||||
|
$this->assertEquals( false, $util->ready() );
|
||||||
|
|
||||||
|
# TODO: Add more tests here to check that if any of the dirs are
|
||||||
|
# then false will be returned. Use strict ordering?
|
||||||
|
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* @brief test checking whether account is ready for encryption, when it is ready
|
||||||
|
*/
|
||||||
|
function testReadyIsReady() {
|
||||||
|
|
||||||
|
$mockView = m::mock('OC_FilesystemView');
|
||||||
|
|
||||||
|
$mockView->shouldReceive( 'file_exists' )->times(3)->andReturn( true );
|
||||||
|
|
||||||
|
$util = new Encryption\Util( $mockView, $this->userId );
|
||||||
|
|
||||||
|
$this->assertEquals( true, $util->ready() );
|
||||||
|
|
||||||
|
# TODO: Add more tests here to check that if any of the dirs are
|
||||||
|
# then false will be returned. Use strict ordering?
|
||||||
|
|
||||||
|
}
|
||||||
|
|
||||||
// // Cannot use this test for now due to hidden dependencies in OC_FileCache
|
// // Cannot use this test for now due to hidden dependencies in OC_FileCache
|
||||||
// function testIsLegacyEncryptedContent() {
|
// function testIsLegacyEncryptedContent() {
|
||||||
|
|
Loading…
Reference in New Issue