diff --git a/apps/contacts/css/jquery.Jcrop.css b/apps/contacts/css/jquery.Jcrop.css index c9b24a5ebe..a9ba4746e0 100644 --- a/apps/contacts/css/jquery.Jcrop.css +++ b/apps/contacts/css/jquery.Jcrop.css @@ -14,7 +14,7 @@ } .jcrop-vline, .jcrop-hline { - background: white url('%webroot%/apps/contacts/img/Jcrop.gif') top left repeat; + background: white url('%appswebroot%/contacts/img/Jcrop.gif') top left repeat; font-size: 0px; position: absolute; } diff --git a/apps/files_versions/appinfo/app.php b/apps/files_versions/appinfo/app.php index ef2f54dd3f..bd06dc0ced 100644 --- a/apps/files_versions/appinfo/app.php +++ b/apps/files_versions/appinfo/app.php @@ -1,6 +1,6 @@ stack_name).'\');'; + return 'javascript:openNewGal(\''.rawurlencode($this->stack_name).'\');'; } private $tiles_array; diff --git a/apps/media/appinfo/app.php b/apps/media/appinfo/app.php index 869bc34402..c5bfc34654 100644 --- a/apps/media/appinfo/app.php +++ b/apps/media/appinfo/app.php @@ -22,9 +22,9 @@ $l=OC_L10N::get('media'); -require_once('apps/media/lib_media.php'); -require_once('apps/media/lib_collection.php'); -require_once('apps/media/lib_scanner.php'); +require_once('media/lib_media.php'); +require_once('media/lib_collection.php'); +require_once('media/lib_scanner.php'); OCP\Util::addscript('media','loader'); OCP\App::registerPersonal('media','settings'); diff --git a/apps/user_ldap/lib_ldap.php b/apps/user_ldap/lib_ldap.php index aa104eb512..c88b18b10d 100644 --- a/apps/user_ldap/lib_ldap.php +++ b/apps/user_ldap/lib_ldap.php @@ -471,11 +471,22 @@ class OC_LDAP { if(!is_null($attr) && !is_array($attr)) { $attr = array(strtolower($attr)); } - $sr = @ldap_search(self::getConnectionResource(), $base, $filter, $attr); - $findings = @ldap_get_entries(self::getConnectionResource(), $sr ); - // if we're here, probably no connection ressource is returned. - // to make ownCloud behave nicely, we simply give back an empty array. - if(is_null($findings)) { + + // See if we have a resource + $link_resource = self::getConnectionResource(); + if($link_resource) + { + $sr = ldap_search($link_resource, $base, $filter, $attr); + $findings = ldap_get_entries($link_resource, $sr ); + // if we're here, probably no connection resource is returned. + // to make ownCloud behave nicely, we simply give back an empty array. + if(is_null($findings)) { + return array(); + } + } else + { + // Seems like we didn't find any resource. + // Return an empty array just like before. return array(); } diff --git a/lib/app.php b/lib/app.php index 486704a222..84d17957de 100755 --- a/lib/app.php +++ b/lib/app.php @@ -492,21 +492,21 @@ class OC_App{ * register a settings form to be shown */ public static function registerSettings($app,$page){ - self::$settingsForms[]='apps/'.$app.'/'.$page.'.php'; + self::$settingsForms[]= $app.'/'.$page.'.php'; } /** * register an admin form to be shown */ public static function registerAdmin($app,$page){ - self::$adminForms[]='apps/'.$app.'/'.$page.'.php'; + self::$adminForms[]= $app.'/'.$page.'.php'; } /** * register a personal form to be shown */ public static function registerPersonal($app,$page){ - self::$personalForms[]='apps/'.$app.'/'.$page.'.php'; + self::$personalForms[]= $app.'/'.$page.'.php'; } /** diff --git a/lib/config.php b/lib/config.php index 65f9fdc06b..266d559126 100644 --- a/lib/config.php +++ b/lib/config.php @@ -157,7 +157,7 @@ class OC_Config{ // Create a php file ... $content = "\n"; + $content .= ";\n"; $filename = OC::$SERVERROOT."/config/config.php"; // Write the file diff --git a/lib/db.php b/lib/db.php index bcc8657b4a..dc9e3392d0 100644 --- a/lib/db.php +++ b/lib/db.php @@ -526,7 +526,7 @@ class OC_DB { self::removeDBStructure( OC::$SERVERROOT . '/db_structure.xml' ); foreach($apps as $app){ - $path = OC::$SERVERROOT.'/apps/'.$app.'/appinfo/database.xml'; + $path = self::getAppPath($app).'/appinfo/database.xml'; if(file_exists($path)){ self::removeDBStructure( $path ); } diff --git a/lib/installer.php b/lib/installer.php index c0903f93d5..00feb6d470 100644 --- a/lib/installer.php +++ b/lib/installer.php @@ -287,22 +287,23 @@ class OC_Installer{ */ public static function installShippedApps(){ foreach(OC::$APPSROOTS as $app_dir) { - $dir = opendir( $app_dir['path'] ); - while( false !== ( $filename = readdir( $dir ))){ - if( substr( $filename, 0, 1 ) != '.' and is_dir($app_dir['path']."/$filename") ){ - if( file_exists( $app_dir['path']."/$filename/appinfo/app.php" )){ - if(!OC_Installer::isInstalled($filename)){ - $info=OC_App::getAppInfo($filename); - $enabled = isset($info['default_enable']); - if( $enabled ){ - OC_Installer::installShippedApp($filename); - OC_Appconfig::setValue($filename,'enabled','yes'); + if($dir = opendir( $app_dir['path'] )){ + while( false !== ( $filename = readdir( $dir ))){ + if( substr( $filename, 0, 1 ) != '.' and is_dir($app_dir['path']."/$filename") ){ + if( file_exists( $app_dir['path']."/$filename/appinfo/app.php" )){ + if(!OC_Installer::isInstalled($filename)){ + $info=OC_App::getAppInfo($filename); + $enabled = isset($info['default_enable']); + if( $enabled ){ + OC_Installer::installShippedApp($filename); + OC_Appconfig::setValue($filename,'enabled','yes'); + } } } } } + closedir( $dir ); } - closedir( $dir ); } } diff --git a/lib/migrate.php b/lib/migrate.php index 5939ba32e5..f26b4b2567 100644 --- a/lib/migrate.php +++ b/lib/migrate.php @@ -64,7 +64,7 @@ class OC_Migrate{ $apps = OC_App::getAllApps(); foreach($apps as $app){ - $path = OC::$SERVERROOT . '/apps/' . $app . '/appinfo/migrate.php'; + $path = self::getAppPath($app) . '/appinfo/migrate.php'; if( file_exists( $path ) ){ include( $path ); } @@ -398,7 +398,7 @@ class OC_Migrate{ if( OC_App::isEnabled( $provider->getID() ) ){ $success = true; // Does this app use the database? - if( file_exists( OC::$SERVERROOT.'/apps/'.$provider->getID().'/appinfo/database.xml' ) ){ + if( file_exists( self::getAppPath($provider->getID()).'/appinfo/database.xml' ) ){ // Create some app tables $tables = self::createAppTables( $provider->getID() ); if( is_array( $tables ) ){ @@ -539,7 +539,7 @@ class OC_Migrate{ } // There is a database.xml file - $content = file_get_contents( OC::$SERVERROOT . '/apps/' . $appid . '/appinfo/database.xml' ); + $content = file_get_contents(self::getAppPath($appid) . '/appinfo/database.xml' ); $file2 = 'static://db_scheme'; // TODO get the relative path to migration.db from the data dir @@ -608,7 +608,7 @@ class OC_Migrate{ static public function getApps(){ $allapps = OC_App::getAllApps(); foreach($allapps as $app){ - $path = OC::$SERVERROOT . '/apps/' . $app . '/lib/migrate.php'; + $path = self::getAppPath($app) . '/lib/migrate.php'; if( file_exists( $path ) ){ $supportsmigration[] = $app; } diff --git a/search/js/result.js b/search/js/result.js index 1087f9684b..27a2383e2c 100644 --- a/search/js/result.js +++ b/search/js/result.js @@ -41,23 +41,13 @@ OC.search.showResults=function(results){ for(var name in types){ var type=types[name]; if(type.length>0){ - var row=$('#searchresults tr.template').clone(); - row.removeClass('template'); - row.addClass('result'); - row.children('td.type').text(name); - row.find('td.result a').attr('href',type[0].link); - row.find('td.result div.name').text(type[0].name); - row.find('td.result div.text').text(type[0].text); - row.data('index',index); - index++; - if(OC.search.customResults[name]){//give plugins the ability to customize the entries in here - OC.search.customResults[name](row,type[0]); - } - $('#searchresults tbody').append(row); - for(var i=1;i