From 6e765ccf39dc8cd0929a0bd28e326f8c4a6c7077 Mon Sep 17 00:00:00 2001
From: Bjoern Schiessle <bjoern@schiessle.org>
Date: Wed, 7 Jun 2017 18:03:47 +0200
Subject: [PATCH] unify look of disabled display name / email address and the
 other input fields

Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
---
 settings/css/settings.css       |  7 +++++++
 settings/templates/personal.php | 14 ++++----------
 2 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/settings/css/settings.css b/settings/css/settings.css
index 9b7cf44ea0..76539d25bd 100644
--- a/settings/css/settings.css
+++ b/settings/css/settings.css
@@ -191,6 +191,13 @@ input#openid, input#webdav {
 	cursor: pointer;
 }
 
+#personal-settings-container input:disabled {
+	background-color: white;
+	color: black;
+	border: none;
+	opacity: 100;
+}
+
 .verification-dialog {
 	display: none;
 	right: -9px;
diff --git a/settings/templates/personal.php b/settings/templates/personal.php
index d492e05d20..296078ad09 100644
--- a/settings/templates/personal.php
+++ b/settings/templates/personal.php
@@ -81,12 +81,9 @@
 				<span class="icon-password"/>
 			</h2>
 			<input type="text" id="displayname" name="displayname"
-				<?php if(!$_['displayNameChangeSupported']) { print_unescaped('class="hidden"'); } ?>
+				<?php if(!$_['displayNameChangeSupported']) { print_unescaped('disabled="1"'); } ?>
 				value="<?php p($_['displayName']) ?>"
 				autocomplete="on" autocapitalize="none" autocorrect="off" />
-			<?php if(!$_['displayNameChangeSupported']) { ?>
-				<span><?php if(isset($_['displayName']) && !empty($_['displayName'])) { p($_['displayName']); } else { p($l->t('No display name set')); } ?></span>
-			<?php } ?>
 			<span class="icon-checkmark hidden"/>
 			<?php if($_['lookupServerUploadEnabled']) { ?>
 			<input type="hidden" id="displaynamescope" value="<?php p($_['displayNameScope']) ?>">
@@ -114,13 +111,10 @@
 				}
 				?>">
 			</div>
-			<input type="email" name="email" id="email" value="<?php p($_['email']); ?>"
-				<?php if(!$_['displayNameChangeSupported']) { print_unescaped('class="hidden"'); } ?>
-				placeholder="<?php p($l->t('Your email address')); ?>"
+			<input type="email" name="email" id="email" value="<?php if(!$_['displayNameChangeSupported'] && empty($_['email'])) p($l->t('No email address set')); else p($_['email']); ?>"
+				<?php if(!$_['displayNameChangeSupported']) { print_unescaped('disabled="1"'); } ?>
+				placeholder="<?php p($l->t('Your email address')) ?>"
 				autocomplete="on" autocapitalize="none" autocorrect="off" />
-			<?php if(!$_['displayNameChangeSupported']) { ?>
-				<span><?php if(isset($_['email']) && !empty($_['email'])) { p($_['email']); } else { p($l->t('No email address set')); }?></span>
-			<?php } ?>
 			<?php if($_['displayNameChangeSupported']) { ?>
 				<br />
 				<em><?php p($l->t('For password reset and notifications')); ?></em>