mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add more caching in the group manager

This commit is contained in:
Bart Visscher 2014-02-21 22:52:48 +01:00
parent 079d64ce75
commit 6f4ecd32b3
1 changed files with 15 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
lib/private/group/manager.php
View File

@ -40,7 +40,12 @@ class Manager extends PublicEmitter {
/** /**
* @var \OC\Group\Group[] * @var \OC\Group\Group[]
*/ */
private $cachedGroups; private $cachedGroups = array();
/**
* @var \OC\Group\Group[]
*/
private $cachedUserGroups = array();
/** /**
* @param \OC\User\Manager $userManager * @param \OC\User\Manager $userManager
@ -141,7 +146,7 @@ class Manager extends PublicEmitter {
$offset -= count($groupIds); $offset -= count($groupIds);
} }
foreach ($groupIds as $groupId) { foreach ($groupIds as $groupId) {
$groups[$groupId] = $this->getGroupObject($groupId); $groups[$groupId] = $this->get($groupId);
} }
if (!is_null($limit) and $limit <= 0) { if (!is_null($limit) and $limit <= 0) {
return array_values($groups); return array_values($groups);
@ -155,13 +160,18 @@ class Manager extends PublicEmitter {
* @return \OC\Group\Group[] * @return \OC\Group\Group[]
*/ */
public function getUserGroups($user) { public function getUserGroups($user) {
$uid = $user->getUID();
if (isset($this->cachedUserGroups[$uid])) {
return $this->cachedUserGroups[$uid];
}
$groups = array(); $groups = array();
foreach ($this->backends as $backend) { foreach ($this->backends as $backend) {
$groupIds = $backend->getUserGroups($user->getUID()); $groupIds = $backend->getUserGroups($uid);
foreach ($groupIds as $groupId) { foreach ($groupIds as $groupId) {
$groups[$groupId] = $this->getGroupObject($groupId); $groups[$groupId] = $this->get($groupId);
} }
} }
return array_values($groups); $this->cachedUserGroups[$uid] = array_values($groups);
return $this->cachedUserGroups[$uid];
} }
} }