diff --git a/apps/files_external/tests/smb.php b/apps/files_external/tests/smb.php index 0291f293fa..199e35af67 100644 --- a/apps/files_external/tests/smb.php +++ b/apps/files_external/tests/smb.php @@ -29,6 +29,11 @@ class SMB extends Storage { } } + public function directoryProvider() { + // doesn't support leading/trailing spaces + return array(array('folder')); + } + public function testRenameWithSpaces() { $this->instance->mkdir('with spaces'); $result = $this->instance->rename('with spaces', 'foo bar'); diff --git a/tests/lib/files/storage/storage.php b/tests/lib/files/storage/storage.php index 6c433e9547..5b5b855685 100644 --- a/tests/lib/files/storage/storage.php +++ b/tests/lib/files/storage/storage.php @@ -236,7 +236,8 @@ abstract class Storage extends \PHPUnit_Framework_TestCase { public function testTouchCreateFile() { $this->assertFalse($this->instance->file_exists('foo')); - $this->instance->touch('foo'); + // returns true on success + $this->assertTrue($this->instance->touch('foo')); $this->assertTrue($this->instance->file_exists('foo')); }