mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

The loading animation is back 

Refactor grant.js to Vanilla JS
Remove id="submit" because of side effects: https://stackoverflow.com/questions/22982741/form-submit-jquery-does-not-work
Fix arrow for login flow v1

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
This commit is contained in:
Daniel Kesselberg 2019-10-26 23:08:52 +02:00
parent 1d82bb55db
commit 71c7442790
No known key found for this signature in database
GPG Key ID: 36E3664E099D0614
3 changed files with 12 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
core/js/login/grant.js
View File

@ -1,9 +1,10 @@
jQuery(document).ready(function() { document.querySelector('form').addEventListener('submit', function(e) {
$('#submit').click(function (e) { const wrapper = document.getElementById('submit-wrapper')
$('#submit + .submit-icon') if (wrapper === null) {
.removeClass('icon-confirm-white') return
.addClass(OCA.Theming && OCA.Theming.inverted }
? 'icon-loading-small' wrapper.getElementsByClassName('icon-confirm-white').forEach(function(el) {
: 'icon-loading-small-dark'); el.classList.remove('icon-confirm-white')
el.classList.add(OCA.Theming && OCA.Theming.inverted ? 'icon-loading-small' : 'icon-loading-small-dark')
}) })
}) })

3
core/templates/loginflow/grant.php
View File

@ -45,8 +45,7 @@ $urlGenerator = $_['urlGenerator'];
<input type="hidden" name="stateToken" value="<?php p($_['stateToken']) ?>" /> <input type="hidden" name="stateToken" value="<?php p($_['stateToken']) ?>" />
<input type="hidden" name="oauthState" value="<?php p($_['oauthState']) ?>" /> <input type="hidden" name="oauthState" value="<?php p($_['oauthState']) ?>" />
<div id="submit-wrapper"> <div id="submit-wrapper">
<input type="submit" id="submit" class="login primary" title="" value="<?php p($l->t('Grant access')); ?>" /> <input type="submit" class="login primary icon-confirm-white" title="" value="<?php p($l->t('Grant access')); ?>" />
<div class="submit-icon icon-confirm-white"></div>
</div> </div>
</form> </form>
</p> </p>

3
core/templates/loginflowv2/grant.php
View File

@ -19,6 +19,7 @@
* *
*/ */
script('core', 'login/grant');
style('core', 'login/authpicker'); style('core', 'login/authpicker');
/** @var array $_ */ /** @var array $_ */
@ -42,7 +43,7 @@ $urlGenerator = $_['urlGenerator'];
<input type="hidden" name="requesttoken" value="<?php p($_['requesttoken']) ?>" /> <input type="hidden" name="requesttoken" value="<?php p($_['requesttoken']) ?>" />
<input type="hidden" name="stateToken" value="<?php p($_['stateToken']) ?>" /> <input type="hidden" name="stateToken" value="<?php p($_['stateToken']) ?>" />
<div id="submit-wrapper"> <div id="submit-wrapper">
<input type="submit" id="submit" class="login primary icon-confirm-white" title="" value="<?php p($l->t('Grant access')); ?>" /> <input type="submit" class="login primary icon-confirm-white" title="" value="<?php p($l->t('Grant access')); ?>" />
</div> </div>
</form> </form>
</p> </p>