Remove deprecated test of internal attributes via assertAttributeEquals in constructor tests
I removed the tests completely because they just test that the constructor assigns the values to the internal properties. Nothing that should be cared about from the outside. See https://github.com/sebastianbergmann/phpunit/issues/3339#issuecomment-428843322 It is seen as bad practice to test internal stuff of objects instead of the actual input and output of mathod calls. Signed-off-by: Morris Jobke <hey@morrisjobke.de>
This commit is contained in:
parent
c813a9e4fb
commit
72fc3ecbfc
|
@ -107,16 +107,6 @@ class CSSResourceLocatorTest extends \Test\TestCase {
|
||||||
return sha1(uniqid(mt_rand(), true));
|
return sha1(uniqid(mt_rand(), true));
|
||||||
}
|
}
|
||||||
|
|
||||||
public function testConstructor() {
|
|
||||||
$locator = $this->cssResourceLocator();
|
|
||||||
$this->assertAttributeEquals('theme', 'theme', $locator);
|
|
||||||
$this->assertAttributeEquals('core', 'serverroot', $locator);
|
|
||||||
$this->assertAttributeEquals(['core'=>'map','3rd'=>'party'], 'mapping', $locator);
|
|
||||||
$this->assertAttributeEquals('3rd', 'thirdpartyroot', $locator);
|
|
||||||
$this->assertAttributeEquals('map', 'webroot', $locator);
|
|
||||||
$this->assertAttributeEquals([], 'resources', $locator);
|
|
||||||
}
|
|
||||||
|
|
||||||
public function testFindWithAppPathSymlink() {
|
public function testFindWithAppPathSymlink() {
|
||||||
// First create new apps path, and a symlink to it
|
// First create new apps path, and a symlink to it
|
||||||
$apps_dirname = $this->randomString();
|
$apps_dirname = $this->randomString();
|
||||||
|
|
|
@ -86,17 +86,6 @@ class JSResourceLocatorTest extends \Test\TestCase {
|
||||||
return sha1(uniqid(mt_rand(), true));
|
return sha1(uniqid(mt_rand(), true));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
public function testConstructor() {
|
|
||||||
$locator = $this->jsResourceLocator();
|
|
||||||
$this->assertAttributeEquals('theme', 'theme', $locator);
|
|
||||||
$this->assertAttributeEquals('core', 'serverroot', $locator);
|
|
||||||
$this->assertAttributeEquals(['core'=>'map','3rd'=>'party'], 'mapping', $locator);
|
|
||||||
$this->assertAttributeEquals('3rd', 'thirdpartyroot', $locator);
|
|
||||||
$this->assertAttributeEquals('map', 'webroot', $locator);
|
|
||||||
$this->assertAttributeEquals([], 'resources', $locator);
|
|
||||||
}
|
|
||||||
|
|
||||||
public function testFindWithAppPathSymlink() {
|
public function testFindWithAppPathSymlink() {
|
||||||
// First create new apps path, and a symlink to it
|
// First create new apps path, and a symlink to it
|
||||||
$apps_dirname = $this->randomString();
|
$apps_dirname = $this->randomString();
|
||||||
|
|
|
@ -33,17 +33,6 @@ class ResourceLocatorTest extends \Test\TestCase {
|
||||||
'', true, true, true, []);
|
'', true, true, true, []);
|
||||||
}
|
}
|
||||||
|
|
||||||
public function testConstructor() {
|
|
||||||
$locator = $this->getResourceLocator('theme',
|
|
||||||
['core'=>'map'], ['3rd'=>'party'], ['foo'=>'bar']);
|
|
||||||
$this->assertAttributeEquals('theme', 'theme', $locator);
|
|
||||||
$this->assertAttributeEquals('core', 'serverroot', $locator);
|
|
||||||
$this->assertAttributeEquals(['core'=>'map','3rd'=>'party'], 'mapping', $locator);
|
|
||||||
$this->assertAttributeEquals('3rd', 'thirdpartyroot', $locator);
|
|
||||||
$this->assertAttributeEquals('map', 'webroot', $locator);
|
|
||||||
$this->assertAttributeEquals([], 'resources', $locator);
|
|
||||||
}
|
|
||||||
|
|
||||||
public function testFind() {
|
public function testFind() {
|
||||||
$locator = $this->getResourceLocator('theme',
|
$locator = $this->getResourceLocator('theme',
|
||||||
['core' => 'map'], ['3rd' => 'party'], ['foo' => 'bar']);
|
['core' => 'map'], ['3rd' => 'party'], ['foo' => 'bar']);
|
||||||
|
|
Loading…
Reference in New Issue