mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Cache: make mounts overwrite existing folders, prevents duplicate entries

This commit is contained in:
Robin Appelman 2013-01-22 20:57:15 +01:00
parent db2b485b96
commit 7330fcf5e8
2 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/files/view.php
View File

@ -794,6 +794,14 @@ class View {
$subPermissionsCache->set($rootEntry['fileid'], $user, $permissions); $subPermissionsCache->set($rootEntry['fileid'], $user, $permissions);
} }
$rootEntry['permissions'] = $permissions; $rootEntry['permissions'] = $permissions;
//remove any existing entry with the same name
foreach ($files as $i => $file) {
if ($file['name'] === $rootEntry['name']) {
unset($files[$i]);
break;
}
}
$files[] = $rootEntry; $files[] = $rootEntry;
} }
} }

12
tests/lib/files/view.php
View File

@ -98,6 +98,18 @@ class View extends \PHPUnit_Framework_TestCase {
$this->assertEquals(array(), $rootView->getDirectoryContent('/non/existing')); $this->assertEquals(array(), $rootView->getDirectoryContent('/non/existing'));
} }
function testMountPointOverwrite() {
$storage1 = $this->getTestStorage(false);
$storage2 = $this->getTestStorage();
$storage1->mkdir('substorage');
\OC\Files\Filesystem::mount($storage1, array(), '/');
\OC\Files\Filesystem::mount($storage2, array(), '/substorage');
$rootView = new \OC\Files\View('');
$folderContent = $rootView->getDirectoryContent('/');
$this->assertEquals(4, count($folderContent));
}
function testCacheIncompleteFolder() { function testCacheIncompleteFolder() {
$storage1 = $this->getTestStorage(false); $storage1 = $this->getTestStorage(false);
\OC\Files\Filesystem::mount($storage1, array(), '/'); \OC\Files\Filesystem::mount($storage1, array(), '/');