mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #26555 from nextcloud/techdebt/noid/run-migrator-tests-on-OCI 

Run migrator tests on OCI
This commit is contained in:
Joas Schilling 2021-04-19 08:57:41 +02:00 committed by GitHub
parent 8c82dd37b4 1670d00452
commit 751be29c73
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 49 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
tests/lib/DB/MigratorTest.php
View File

@ -10,6 +10,7 @@
namespace Test\DB; namespace Test\DB;
use Doctrine\DBAL\Exception; use Doctrine\DBAL\Exception;
use Doctrine\DBAL\ParameterType;
use Doctrine\DBAL\Platforms\MySQLPlatform; use Doctrine\DBAL\Platforms\MySQLPlatform;
use Doctrine\DBAL\Platforms\OraclePlatform; use Doctrine\DBAL\Platforms\OraclePlatform;
use Doctrine\DBAL\Platforms\PostgreSQL94Platform; use Doctrine\DBAL\Platforms\PostgreSQL94Platform;
@ -21,6 +22,7 @@ use OC\DB\MySQLMigrator;
use OC\DB\OracleMigrator; use OC\DB\OracleMigrator;
use OC\DB\PostgreSqlMigrator; use OC\DB\PostgreSqlMigrator;
use OC\DB\SQLiteMigrator; use OC\DB\SQLiteMigrator;
use OCP\DB\Types;
use OCP\IConfig; use OCP\IConfig;
/** /**
@ -52,9 +54,6 @@ class MigratorTest extends \Test\TestCase {
$this->config = \OC::$server->getConfig(); $this->config = \OC::$server->getConfig();
$this->connection = \OC::$server->get(\OC\DB\Connection::class); $this->connection = \OC::$server->get(\OC\DB\Connection::class);
if ($this->connection->getDatabasePlatform() instanceof OraclePlatform) {
$this->markTestSkipped('DB migration tests are not supported on OCI');
}
$this->tableName = $this->getUniqueTableName(); $this->tableName = $this->getUniqueTableName();
$this->tableNameTmp = $this->getUniqueTableName(); $this->tableNameTmp = $this->getUniqueTableName();
@ -257,4 +256,51 @@ class MigratorTest extends \Test\TestCase {
$this->assertTrue($startSchema->getTable($this->tableNameTmp)->hasForeignKey($fkName)); $this->assertTrue($startSchema->getTable($this->tableNameTmp)->hasForeignKey($fkName));
} }
public function dataNotNullEmptyValuesFailOracle(): array {
return [
[ParameterType::BOOLEAN, true, Types::BOOLEAN, false],
[ParameterType::BOOLEAN, false, Types::BOOLEAN, true],
[ParameterType::STRING, 'foo', Types::STRING, false],
[ParameterType::STRING, '', Types::STRING, true],
[ParameterType::INTEGER, 1234, Types::INTEGER, false],
[ParameterType::INTEGER, 0, Types::INTEGER, false], // Integer 0 is not stored as Null and therefor works
];
}
/**
* @dataProvider dataNotNullEmptyValuesFailOracle
*
* @param int $parameterType
* @param bool|int|string $value
* @param string $columnType
* @param bool $oracleThrows
*/
public function testNotNullEmptyValuesFailOracle(int $parameterType, $value, string $columnType, bool $oracleThrows): void {
$startSchema = new Schema([], [], $this->getSchemaConfig());
$table = $startSchema->createTable($this->tableName);
$table->addColumn('id', Types::BIGINT);
$table->addColumn('will_it_blend', $columnType, [
'notnull' => true,
]);
$table->addIndex(['id'], $this->tableName . '_id');
$migrator = $this->getMigrator();
$migrator->migrate($startSchema);
if ($oracleThrows && $this->connection->getDatabasePlatform() instanceof OraclePlatform) {
// Oracle can not store false|empty string in notnull columns
$this->expectException(\Doctrine\DBAL\Exception\NotNullConstraintViolationException::class);
}
$this->connection->insert(
$this->tableName,
['id' => 1, 'will_it_blend' => $value],
['id' => ParameterType::INTEGER, 'will_it_blend' => $parameterType],
);
$this->addToAssertionCount(1);
}
} }