From 756fe45493fd3b82284abcedc51528542edc43bf Mon Sep 17 00:00:00 2001 From: Robin Appelman Date: Mon, 4 May 2020 17:42:28 +0200 Subject: [PATCH] get only groupids in default share backend instead of getting the full group object and then only using the id anyway Signed-off-by: Robin Appelman --- lib/private/Share20/DefaultShareProvider.php | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/lib/private/Share20/DefaultShareProvider.php b/lib/private/Share20/DefaultShareProvider.php index ff46badee3..c2de03ea68 100644 --- a/lib/private/Share20/DefaultShareProvider.php +++ b/lib/private/Share20/DefaultShareProvider.php @@ -888,7 +888,7 @@ class DefaultShareProvider implements IShareProvider { $cursor->closeCursor(); } elseif ($shareType === \OCP\Share::SHARE_TYPE_GROUP) { $user = $this->userManager->get($userId); - $allGroups = $this->groupManager->getUserGroups($user); + $allGroups = $this->groupManager->getUserGroupIds($user); /** @var Share[] $shares2 */ $shares2 = []; @@ -925,12 +925,7 @@ class DefaultShareProvider implements IShareProvider { } - $groups = array_filter($groups, function ($group) { - return $group instanceof IGroup; - }); - $groups = array_map(function (IGroup $group) { - return $group->getGID(); - }, $groups); + $groups = array_filter($groups); $qb->andWhere($qb->expr()->eq('share_type', $qb->createNamedParameter(\OCP\Share::SHARE_TYPE_GROUP))) ->andWhere($qb->expr()->in('share_with', $qb->createNamedParameter(