mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Made code formatting of new methods more consistent

This commit is contained in:
Sam Tuke 2013-05-07 17:16:16 +02:00
parent 4b53f72d0d
commit 763c8f78ed
1 changed files with 157 additions and 118 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

275
apps/files_encryption/hooks/hooks.php
View File

@ -183,7 +183,7 @@ class Hooks {
/** /**
* @brief * @brief
*/ */
public static function postShared($params) { public static function postShared( $params ) {
// NOTE: $params has keys: // NOTE: $params has keys:
// [itemType] => file // [itemType] => file
@ -202,89 +202,109 @@ class Hooks {
// [id] => 10 // [id] => 10
// [token] => // [token] =>
// TODO: Should other kinds of item be encrypted too? // TODO: Should other kinds of item be encrypted too?
if ($params['itemType'] === 'file' || $params['itemType'] === 'folder') {
if ( $params['itemType'] === 'file' || $params['itemType'] === 'folder' ) {
$view = new \OC_FilesystemView('/'); $view = new \OC_FilesystemView( '/' );
$session = new Session($view); $session = new Session($view);
$userId = \OCP\User::getUser(); $userId = \OCP\User::getUser();
$util = new Util($view, $userId); $util = new Util($view, $userId);
$path = $util->fileIdToPath($params['itemSource']); $path = $util->fileIdToPath( $params['itemSource'] );
//if parent is set, then this is a re-share action //if parent is set, then this is a re-share action
if($params['parent']) { if( $params['parent'] ) {
// get the parent from current share // get the parent from current share
$parent = $util->getShareParent($params['parent']); $parent = $util->getShareParent( $params['parent'] );
// if parent is file the it is an 1:1 share // if parent is file the it is an 1:1 share
if($parent['item_type'] === 'file') { if($parent['item_type'] === 'file') {
// prefix path with Shared // prefix path with Shared
$path = '/Shared'.$parent['file_target']; $path = '/Shared'.$parent['file_target'];
} else { } else {
// parent is folder but shared was a file!
// we try to rebuild the missing path // NOTE: parent is folder but shared was a file!
// some examples we face here // we try to rebuild the missing path
// user1 share folder1 with user2 folder1 has the following structure /folder1/subfolder1/subsubfolder1/somefile.txt // some examples we face here
// user2 re-share subfolder2 with user3 // user1 share folder1 with user2 folder1 has
// user3 re-share somefile.txt user4 // the following structure
// so our path should be /Shared/subfolder1/subsubfolder1/somefile.txt while user3 is sharing // /folder1/subfolder1/subsubfolder1/somefile.txt
if($params['itemType'] === 'file') { // user2 re-share subfolder2 with user3
// get target path // user3 re-share somefile.txt user4
$targetPath = $util->fileIdToPath($params['fileSource']); // so our path should be
$targetPathSplit = array_reverse(explode('/', $targetPath)); // /Shared/subfolder1/subsubfolder1/somefile.txt
// while user3 is sharing
if ( $params['itemType'] === 'file' ) {
// get target path
$targetPath = $util->fileIdToPath( $params['fileSource'] );
$targetPathSplit = array_reverse( explode( '/', $targetPath ) );
// init values // init values
$path = ''; $path = '';
$sharedPart = ltrim( $parent['file_target'], '/' ); $sharedPart = ltrim( $parent['file_target'], '/' );
// rebuild path // rebuild path
foreach ($targetPathSplit as $pathPart) { foreach ( $targetPathSplit as $pathPart ) {
if($pathPart !== $sharedPart) {
$path = '/'.$pathPart.$path; if( $pathPart !== $sharedPart ) {
} else {
break; $path = '/' . $pathPart . $path;
}
} } else {
break;
}
}
// prefix path with Shared // prefix path with Shared
$path = '/Shared'.$parent['file_target'].$path; $path = '/Shared'.$parent['file_target'].$path;
} else { } else {
// prefix path with Shared // prefix path with Shared
$path = '/Shared'.$parent['file_target'].$params['fileTarget']; $path = '/Shared'.$parent['file_target'].$params['fileTarget'];
} }
} }
}
$sharingEnabled = \OCP\Share::isEnabled();
// if a folder was shared, get a list if all (sub-)folders
if ($params['itemType'] === 'folder') {
$allFiles = $util->getAllFiles($path);
} else {
$allFiles = array($path);
} }
foreach ($allFiles as $path) { $sharingEnabled = \OCP\Share::isEnabled();
$usersSharing = $util->getSharingUsersArray($sharingEnabled, $path);
// if a folder was shared, get a list if all (sub-)folders
if ( $params['itemType'] === 'folder' ) {
$allFiles = $util->getAllFiles($path);
} else {
$allFiles = array( $path );
}
foreach ( $allFiles as $path ) {
$usersSharing = $util->getSharingUsersArray( $sharingEnabled, $path );
$failed = array(); $failed = array();
// Attempt to set shareKey // Attempt to set shareKey
if (!$util->setSharedFileKeyfiles($session, $usersSharing, $path)) { if ( !$util->setSharedFileKeyfiles( $session, $usersSharing, $path ) ) {
$failed[] = $path; $failed[] = $path;
} }
} }
// If no attempts to set keyfiles failed // If no attempts to set keyfiles failed
if (empty($failed)) { if ( empty( $failed ) ) {
return true; return true;
} else { } else {
return false; return false;
} }
} }
} }
@ -292,85 +312,104 @@ class Hooks {
/** /**
* @brief * @brief
*/ */
public static function postUnshare($params) public static function postUnshare( $params ) {
{
// NOTE: $params has keys: // NOTE: $params has keys:
// [itemType] => file // [itemType] => file
// [itemSource] => 13 // [itemSource] => 13
// [shareType] => 0 // [shareType] => 0
// [shareWith] => test1 // [shareWith] => test1
// [itemParent] => // [itemParent] =>
if ($params['itemType'] === 'file' || $params['itemType'] === 'folder') { if ( $params['itemType'] === 'file' || $params['itemType'] === 'folder' ) {
$view = new \OC_FilesystemView('/'); $view = new \OC_FilesystemView( '/' );
$userId = \OCP\User::getUser(); $userId = \OCP\User::getUser();
$util = new Util($view, $userId); $util = new Util( $view, $userId);
$path = $util->fileIdToPath($params['itemSource']); $path = $util->fileIdToPath( $params['itemSource'] );
// check if this is a re-share // check if this is a re-share
if ($params['itemParent']) { if ( $params['itemParent'] ) {
// get the parent from current share // get the parent from current share
$parent = $util->getShareParent($params['itemParent']); $parent = $util->getShareParent( $params['itemParent'] );
// get target path // get target path
$targetPath = $util->fileIdToPath($params['itemSource']); $targetPath = $util->fileIdToPath( $params['itemSource'] );
$targetPathSplit = array_reverse(explode('/', $targetPath)); $targetPathSplit = array_reverse( explode( '/', $targetPath ) );
// init values // init values
$path = ''; $path = '';
$sharedPart = ltrim($parent['file_target'], '/'); $sharedPart = ltrim( $parent['file_target'], '/' );
// rebuild path // rebuild path
foreach ($targetPathSplit as $pathPart) { foreach ( $targetPathSplit as $pathPart ) {
if ($pathPart !== $sharedPart) {
$path = '/' . $pathPart . $path; if ( $pathPart !== $sharedPart ) {
} else {
break; $path = '/' . $pathPart . $path;
}
} } else {
break;
}
}
// prefix path with Shared // prefix path with Shared
$path = '/Shared' . $parent['file_target'] . $path; $path = '/Shared' . $parent['file_target'] . $path;
} }
// for group shares get a list of the group members // for group shares get a list of the group members
if ($params['shareType'] == \OCP\Share::SHARE_TYPE_GROUP) { if ( $params['shareType'] == \OCP\Share::SHARE_TYPE_GROUP ) {
$userIds = \OC_Group::usersInGroup($params['shareWith']);
} else { $userIds = \OC_Group::usersInGroup($params['shareWith']);
$userIds = array($params['shareWith']);
} } else {
$userIds = array( $params['shareWith'] );
}
// if we unshare a folder we need a list of all (sub-)files // if we unshare a folder we need a list of all (sub-)files
if ($params['itemType'] === 'folder') { if ( $params['itemType'] === 'folder' ) {
$allFiles = $util->getAllFiles($path);
} else { $allFiles = $util->getAllFiles( $path );
$allFiles = array($path);
} } else {
$allFiles = array( $path );
}
foreach ($allFiles as $path) { foreach ( $allFiles as $path ) {
// check if the user still has access to the file, otherwise delete share key // check if the user still has access to the file, otherwise delete share key
$sharingUsers = $util->getSharingUsersArray(true, $path); $sharingUsers = $util->getSharingUsersArray( true, $path );
// Unshare every user who no longer has access to the file // Unshare every user who no longer has access to the file
$delUsers = array_diff($userIds, $sharingUsers); $delUsers = array_diff( $userIds, $sharingUsers);
if (!Keymanager::delShareKey($view, $delUsers, $path)) {
$failed[] = $path; if ( !Keymanager::delShareKey( $view, $delUsers, $path ) ) {
}
$failed[] = $path;
}
} }
// If no attempts to set keyfiles failed // If no attempts to set keyfiles failed
if (empty($failed)) { if ( empty( $failed ) ) {
return true;
} else { return true;
return false;
} } else {
}
} return false;
}
}
}
/** /**
* @brief * @brief