remove double loop for detecting changed mounts
Signed-off-by: Robin Appelman <robin@icewind.nl>
This commit is contained in:
parent
487dc0bf00
commit
76780e313c
|
@ -134,16 +134,19 @@ class UserMountCache implements IUserMountCache {
|
||||||
* @return ICachedMountInfo[]
|
* @return ICachedMountInfo[]
|
||||||
*/
|
*/
|
||||||
private function findChangedMounts(array $newMounts, array $cachedMounts) {
|
private function findChangedMounts(array $newMounts, array $cachedMounts) {
|
||||||
|
$new = [];
|
||||||
|
foreach ($newMounts as $mount) {
|
||||||
|
$new[$mount->getRootId()] = $mount;
|
||||||
|
}
|
||||||
$changed = [];
|
$changed = [];
|
||||||
foreach ($newMounts as $newMount) {
|
foreach ($cachedMounts as $cachedMount) {
|
||||||
foreach ($cachedMounts as $cachedMount) {
|
$rootId = $cachedMount->getRootId();
|
||||||
|
if (isset($new[$rootId])) {
|
||||||
|
$newMount = $new[$rootId];
|
||||||
if (
|
if (
|
||||||
$newMount->getRootId() === $cachedMount->getRootId() &&
|
$newMount->getMountPoint() !== $cachedMount->getMountPoint() ||
|
||||||
(
|
$newMount->getStorageId() !== $cachedMount->getStorageId() ||
|
||||||
$newMount->getMountPoint() !== $cachedMount->getMountPoint() ||
|
$newMount->getMountId() !== $cachedMount->getMountId()
|
||||||
$newMount->getStorageId() !== $cachedMount->getStorageId() ||
|
|
||||||
$newMount->getMountId() !== $cachedMount->getMountId()
|
|
||||||
)
|
|
||||||
) {
|
) {
|
||||||
$changed[] = $newMount;
|
$changed[] = $newMount;
|
||||||
}
|
}
|
||||||
|
@ -196,7 +199,7 @@ class UserMountCache implements IUserMountCache {
|
||||||
}
|
}
|
||||||
$mount_id = $row['mount_id'];
|
$mount_id = $row['mount_id'];
|
||||||
if (!is_null($mount_id)) {
|
if (!is_null($mount_id)) {
|
||||||
$mount_id = (int) $mount_id;
|
$mount_id = (int)$mount_id;
|
||||||
}
|
}
|
||||||
return new CachedMountInfo($user, (int)$row['storage_id'], (int)$row['root_id'], $row['mount_point'], $mount_id, isset($row['path'])? $row['path']:'');
|
return new CachedMountInfo($user, (int)$row['storage_id'], (int)$row['root_id'], $row['mount_point'], $mount_id, isset($row['path'])? $row['path']:'');
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue