Merge pull request #24706 from nextcloud/bugfix/noid/log-error-on-setting-custom-headers-on-no-content-responses
Log an error when setting a custom header on "Not Modified" responses
This commit is contained in:
commit
7a77493038
|
@ -38,6 +38,8 @@ namespace OCP\AppFramework\Http;
|
||||||
|
|
||||||
use OCP\AppFramework\Http;
|
use OCP\AppFramework\Http;
|
||||||
use OCP\AppFramework\Utility\ITimeFactory;
|
use OCP\AppFramework\Utility\ITimeFactory;
|
||||||
|
use OCP\IConfig;
|
||||||
|
use Psr\Log\LoggerInterface;
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Base class for responses. Also used to just send headers.
|
* Base class for responses. Also used to just send headers.
|
||||||
|
@ -203,6 +205,18 @@ class Response {
|
||||||
// to be able to reliably check for security
|
// to be able to reliably check for security
|
||||||
// headers
|
// headers
|
||||||
|
|
||||||
|
if ($this->status === Http::STATUS_NOT_MODIFIED
|
||||||
|
&& stripos($name, 'x-') === 0) {
|
||||||
|
/** @var IConfig $config */
|
||||||
|
$config = \OC::$server->get(IConfig::class);
|
||||||
|
|
||||||
|
if ($config->getSystemValueBool('debug', false)) {
|
||||||
|
\OC::$server->get(LoggerInterface::class)->error(
|
||||||
|
'Setting a custom header on a 204 or 304 is not supported'
|
||||||
|
);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
if (is_null($value)) {
|
if (is_null($value)) {
|
||||||
unset($this->headers[$name]);
|
unset($this->headers[$name]);
|
||||||
} else {
|
} else {
|
||||||
|
|
Loading…
Reference in New Issue