mbk-lab
/
nextcloud
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Better checking of ajax paramters and better logging

This commit is contained in:
Tom Needham 2012-05-08 19:48:28 +00:00
parent 9c47346373
commit 7dcf38c40f
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
apps/files_texteditor/ajax/savefile.php
View File

@ -28,11 +28,11 @@
OCP\JSON::checkLoggedIn(); OCP\JSON::checkLoggedIn();
// Get paramteres // Get paramteres
$filecontents = $_POST['filecontents']; $filecontents = isset($_POST['filecontents']) ? $_POST['filecontents'] : false;
$path = isset($_POST['path']) ? $_POST['path'] : ''; $path = isset($_POST['path']) ? $_POST['path'] : '';
$mtime = isset($_POST['mtime']) ? $_POST['mtime'] : ''; $mtime = isset($_POST['mtime']) ? $_POST['mtime'] : '';
if($path != '' && $mtime != '') if($path != '' && $mtime != '' && $filecontents)
{ {
// Get file mtime // Get file mtime
$filemtime = OC_Filesystem::filemtime($path); $filemtime = OC_Filesystem::filemtime($path);
@ -62,7 +62,13 @@ if($path != '' && $mtime != '')
OCP\Util::writeLog('files_texteditor',"User does not have permission to write to file: ".$path,OCP\Util::ERROR); OCP\Util::writeLog('files_texteditor',"User does not have permission to write to file: ".$path,OCP\Util::ERROR);
} }
} }
} else { } else if($path == ''){
OCP\JSON::error(array('data' => array( 'message' => 'File path or mtime not supplied'))); OCP\JSON::error(array('data' => array( 'message' => 'File path not supplied')));
OCP\Util::writeLog('files_texteditor',"Invalid path supplied:".$path,OCP\Util::ERROR); OCP\Util::writeLog('files_texteditor','No file path supplied', OCP\Util::ERROR);
} else if($mtime == ''){
OCP\JSON::error(array('data' => array( 'message' => 'File mtime not supplied')));
OCP\Util::writeLog('files_texteditor','No file mtime supplied' ,OCP\Util::ERROR);
} else if(!$filecontents){
OCP\JSON::error(array('data' => array( 'message' => 'File contents not supplied')));
OCP\Util::writeLog('files_texteditor','The file contents was not supplied',OCP\Util::ERROR);
} }