Fix unit tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
This commit is contained in:
parent
b974dd5b73
commit
81455479bc
|
@ -107,7 +107,7 @@ class CommentsNodeTest extends \Test\TestCase {
|
|||
$this->node->delete();
|
||||
}
|
||||
|
||||
|
||||
|
||||
public function testDeleteForbidden() {
|
||||
$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
|
||||
|
||||
|
@ -149,7 +149,7 @@ class CommentsNodeTest extends \Test\TestCase {
|
|||
$this->assertSame($this->node->getName(), $id);
|
||||
}
|
||||
|
||||
|
||||
|
||||
public function testSetName() {
|
||||
$this->expectException(\Sabre\DAV\Exception\MethodNotAllowed::class);
|
||||
|
||||
|
@ -194,7 +194,7 @@ class CommentsNodeTest extends \Test\TestCase {
|
|||
$this->assertTrue($this->node->updateComment($msg));
|
||||
}
|
||||
|
||||
|
||||
|
||||
public function testUpdateCommentLogException() {
|
||||
$this->expectException(\Exception::class);
|
||||
$this->expectExceptionMessage('buh!');
|
||||
|
@ -235,7 +235,7 @@ class CommentsNodeTest extends \Test\TestCase {
|
|||
$this->node->updateComment($msg);
|
||||
}
|
||||
|
||||
|
||||
|
||||
public function testUpdateCommentMessageTooLongException() {
|
||||
$this->expectException(\Sabre\DAV\Exception\BadRequest::class);
|
||||
$this->expectExceptionMessage('Message exceeds allowed character limit of');
|
||||
|
@ -274,7 +274,7 @@ class CommentsNodeTest extends \Test\TestCase {
|
|||
$this->node->updateComment('foo');
|
||||
}
|
||||
|
||||
|
||||
|
||||
public function testUpdateForbiddenByUser() {
|
||||
$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
|
||||
|
||||
|
@ -309,7 +309,7 @@ class CommentsNodeTest extends \Test\TestCase {
|
|||
$this->node->updateComment($msg);
|
||||
}
|
||||
|
||||
|
||||
|
||||
public function testUpdateForbiddenByType() {
|
||||
$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
|
||||
|
||||
|
@ -339,7 +339,7 @@ class CommentsNodeTest extends \Test\TestCase {
|
|||
$this->node->updateComment($msg);
|
||||
}
|
||||
|
||||
|
||||
|
||||
public function testUpdateForbiddenByNotLoggedIn() {
|
||||
$this->expectException(\Sabre\DAV\Exception\Forbidden::class);
|
||||
|
||||
|
@ -402,6 +402,7 @@ class CommentsNodeTest extends \Test\TestCase {
|
|||
$ns . 'latestChildDateTime' => new \DateTime('2016-01-12 18:48:00'),
|
||||
$ns . 'objectType' => 'files',
|
||||
$ns . 'objectId' => '1848',
|
||||
$ns . 'referenceId' => 'ref',
|
||||
$ns . 'isUnread' => null,
|
||||
];
|
||||
|
||||
|
@ -468,6 +469,10 @@ class CommentsNodeTest extends \Test\TestCase {
|
|||
->method('getObjectId')
|
||||
->willReturn($expected[$ns . 'objectId']);
|
||||
|
||||
$this->comment->expects($this->once())
|
||||
->method('getReferenceId')
|
||||
->willReturn($expected[$ns . 'referenceId']);
|
||||
|
||||
$user = $this->getMockBuilder(IUser::class)
|
||||
->disableOriginalConstructor()
|
||||
->getMock();
|
||||
|
@ -483,7 +488,7 @@ class CommentsNodeTest extends \Test\TestCase {
|
|||
$properties = $this->node->getProperties(null);
|
||||
|
||||
foreach($properties as $name => $value) {
|
||||
$this->assertTrue(array_key_exists($name, $expected));
|
||||
$this->assertArrayHasKey($name, $expected);
|
||||
$this->assertSame($expected[$name], $value);
|
||||
unset($expected[$name]);
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue