diff --git a/settings/ajax/changepassword.php b/settings/ajax/changepassword.php deleted file mode 100644 index 47ceb5ab87..0000000000 --- a/settings/ajax/changepassword.php +++ /dev/null @@ -1,64 +0,0 @@ - array('message' => 'Authentication error'))); - exit(); -} - -if (\OCP\App::isEnabled('files_encryption') && $userstatus !== 'user') { - //handle the recovery case - $util = new \OCA\Encryption\Util(new \OC_FilesystemView('/'), $username); - $recoveryAdminEnabled = OC_Appconfig::getValue('files_encryption', 'recoveryAdminEnabled'); - - $validRecoveryPassword = false; - $recoveryPasswordSupported = false; - if ($recoveryAdminEnabled) { - $validRecoveryPassword = $util->checkRecoveryPassword($recoveryPassword); - $recoveryEnabledForUser = $util->recoveryEnabledForUser(); - } - - if ($recoveryEnabledForUser && $recoveryPassword === '') { - OC_JSON::error(array('data' => array('message' => 'Please provide a admin recovery password, otherwise all user data will be lost'))); - } elseif ($recoveryEnabledForUser && ! $validRecoveryPassword) { - OC_JSON::error(array('data' => array('message' => 'Wrong admin recovery password. Please check the password and try again.'))); - } else { // now we know that everything is fine regarding the recovery password, let's try to change the password - $result = OC_User::setPassword($username, $password, $recoveryPassword); - if (!$result && $recoveryPasswordSupported) { - OC_JSON::error(array("data" => array( "message" => "Back-end doesn't support password change, but the users encryption key was successfully updated." ))); - } elseif (!$result && !$recoveryPasswordSupported) { - OC_JSON::error(array("data" => array( "message" => "Unable to change password" ))); - } else { - OC_JSON::success(array("data" => array( "username" => $username ))); - } - - } -} else { // if user changes his own password or if encryption is disabled, proceed - if (!is_null($password) && OC_User::setPassword($username, $password)) { - OC_JSON::success(array('data' => array('username' => $username))); - } else { - OC_JSON::error(array('data' => array('message' => 'Unable to change password'))); - } -} diff --git a/settings/changepassword/controller.php b/settings/changepassword/controller.php new file mode 100644 index 0000000000..1ecb644a96 --- /dev/null +++ b/settings/changepassword/controller.php @@ -0,0 +1,107 @@ + array("message" => $l->t("Wrong password")) )); + exit(); + } + if (!is_null($password) && \OC_User::setPassword($username, $password)) { + \OC_JSON::success(); + } else { + \OC_JSON::error(); + } + } + + public static function changeUserPassword($args) { + // Check if we are an user + \OC_JSON::callCheck(); + \OC_JSON::checkLoggedIn(); + + // Manually load apps to ensure hooks work correctly (workaround for issue 1503) + \OC_App::loadApps(); + + if (isset($_POST['username'])) { + $username = $_POST['username']; + } else { + $l = new \OC_L10n('settings'); + \OC_JSON::error(array('data' => array('message' => $l->t('No user supplied')) )); + exit(); + } + + $password = isset($_POST['password']) ? $_POST['password'] : null; + $recoveryPassword = isset($_POST['recoveryPassword']) ? $_POST['recoveryPassword'] : null; + + if (\OC_User::isAdminUser(\OC_User::getUser())) { + $userstatus = 'admin'; + } elseif (\OC_SubAdmin::isUserAccessible(\OC_User::getUser(), $username)) { + $userstatus = 'subadmin'; + } else { + $l = new \OC_L10n('settings'); + \OC_JSON::error(array('data' => array('message' => $l->t('Authentication error')) )); + exit(); + } + + if (\OC_App::isEnabled('files_encryption')) { + //handle the recovery case + $util = new \OCA\Encryption\Util(new \OC_FilesystemView('/'), $username); + $recoveryAdminEnabled = \OC_Appconfig::getValue('files_encryption', 'recoveryAdminEnabled'); + + $validRecoveryPassword = false; + $recoveryPasswordSupported = false; + if ($recoveryAdminEnabled) { + $validRecoveryPassword = $util->checkRecoveryPassword($recoveryPassword); + $recoveryEnabledForUser = $util->recoveryEnabledForUser(); + } + + if ($recoveryEnabledForUser && $recoveryPassword === '') { + $l = new \OC_L10n('settings'); + \OC_JSON::error(array('data' => array( + 'message' => $l->t('Please provide an admin recovery password, otherwise all user data will be lost') + ))); + } elseif ($recoveryEnabledForUser && ! $validRecoveryPassword) { + $l = new \OC_L10n('settings'); + \OC_JSON::error(array('data' => array( + 'message' => $l->t('Wrong admin recovery password. Please check the password and try again.') + ))); + } else { // now we know that everything is fine regarding the recovery password, let's try to change the password + $result = \OC_User::setPassword($username, $password, $recoveryPassword); + if (!$result && $recoveryPasswordSupported) { + $l = new \OC_L10n('settings'); + \OC_JSON::error(array( + "data" => array( + "message" => $l->t("Back-end doesn't support password change, but the users encryption key was successfully updated.") + ) + )); + } elseif (!$result && !$recoveryPasswordSupported) { + $l = new \OC_L10n('settings'); + \OC_JSON::error(array("data" => array( $l->t("message" => "Unable to change password" ) ))); + } else { + \OC_JSON::success(array("data" => array( "username" => $username ))); + } + + } + } else { // if encryption is disabled, proceed + if (!is_null($password) && \OC_User::setPassword($username, $password)) { + \OC_JSON::success(array('data' => array('username' => $username))); + } else { + $l = new \OC_L10n('settings'); + \OC_JSON::error(array('data' => array('message' => $l->t('Unable to change password')))); + } + } + } +} diff --git a/settings/js/personal.js b/settings/js/personal.js index fab32b83b6..eaaca32f5d 100644 --- a/settings/js/personal.js +++ b/settings/js/personal.js @@ -124,14 +124,17 @@ $(document).ready(function(){ $('#passwordchanged').hide(); $('#passworderror').hide(); // Ajax foo - $.post( 'ajax/changepassword.php', post, function(data){ + $.post(OC.Router.generate('settings_personal_changepassword'), post, function(data){ if( data.status === "success" ){ $('#pass1').val(''); $('#pass2').val(''); $('#passwordchanged').show(); - } - else{ - $('#passworderror').html( data.data.message ); + } else{ + if (typeof(data.data) !== "undefined") { + $('#passworderror').html(data.data.message); + } else { + $('#passworderror').html(t('Unable to change password')); + } $('#passworderror').show(); } }); diff --git a/settings/js/users.js b/settings/js/users.js index 01a845367e..48c4529527 100644 --- a/settings/js/users.js +++ b/settings/js/users.js @@ -361,7 +361,7 @@ $(document).ready(function () { if ($(this).val().length > 0) { var recoveryPasswordVal = $('input:password[id="recoveryPassword"]').val(); $.post( - OC.filePath('settings', 'ajax', 'changepassword.php'), + OC.Router.generate('settings_users_changepassword'), {username: uid, password: $(this).val(), recoveryPassword: recoveryPasswordVal}, function (result) { if (result.status != 'success') { diff --git a/settings/routes.php b/settings/routes.php index 73ee70d1d5..60f9d8e100 100644 --- a/settings/routes.php +++ b/settings/routes.php @@ -37,11 +37,15 @@ $this->create('settings_ajax_togglesubadmins', '/settings/ajax/togglesubadmins.p ->actionInclude('settings/ajax/togglesubadmins.php'); $this->create('settings_ajax_removegroup', '/settings/ajax/removegroup.php') ->actionInclude('settings/ajax/removegroup.php'); -$this->create('settings_ajax_changepassword', '/settings/ajax/changepassword.php') - ->actionInclude('settings/ajax/changepassword.php'); +$this->create('settings_users_changepassword', '/settings/users/changepassword') + ->post() + ->action('OC\Settings\ChangePassword\Controller', 'changeUserPassword'); $this->create('settings_ajax_changedisplayname', '/settings/ajax/changedisplayname.php') ->actionInclude('settings/ajax/changedisplayname.php'); -// personel +// personal +$this->create('settings_personal_changepassword', '/settings/personal/changepassword') + ->post() + ->action('OC\Settings\ChangePassword\Controller', 'changePersonalPassword'); $this->create('settings_ajax_lostpassword', '/settings/ajax/lostpassword.php') ->actionInclude('settings/ajax/lostpassword.php'); $this->create('settings_ajax_setlanguage', '/settings/ajax/setlanguage.php')