Better unique names for temporary tables

This commit is contained in:
Robin Appelman 2014-06-03 11:24:31 +02:00
parent 3be2643168
commit 82b982a4eb
2 changed files with 19 additions and 1 deletions

View File

@ -77,6 +77,16 @@ class Migrator {
}
}
/**
* Create a unique name for the temporary table
*
* @param string $name
* @return string
*/
protected function generateTemporaryTableName($name) {
return 'oc_' . $name . '_' . uniqid();
}
/**
* Check the migration of a table on a copy so we can detect errors before messing with the real table
*
@ -85,7 +95,7 @@ class Migrator {
*/
protected function checkTableMigrate(Table $table) {
$name = $table->getName();
$tmpName = 'oc_' . uniqid();
$tmpName = $this->generateTemporaryTableName($name);
$this->copyTable($name, $tmpName);

View File

@ -29,4 +29,12 @@ class OracleMigrator extends NoCheckMigrator {
return $schemaDiff;
}
/**
* @param string $name
* @return string
*/
protected function generateTemporaryTableName($name) {
return 'oc_' . uniqid();
}
}