From bac2683c55a87f174bc5001630ac6913e659d1f4 Mon Sep 17 00:00:00 2001 From: Jan-Christoph Borchardt Date: Wed, 17 Dec 2014 11:26:42 +0100 Subject: [PATCH 1/9] fix alt text for breadcrumbs home icon --- apps/files/js/breadcrumb.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/apps/files/js/breadcrumb.js b/apps/files/js/breadcrumb.js index af4e48c8f8..5cea2639c7 100644 --- a/apps/files/js/breadcrumb.js +++ b/apps/files/js/breadcrumb.js @@ -106,6 +106,7 @@ if (part.img) { $image = $(''); $image.attr('src', part.img); + $image.attr('alt', part.alt); $link.append($image); } this.breadcrumbs.push($crumb); @@ -151,6 +152,7 @@ crumbs.push({ dir: '/', name: '', + alt: t('files', 'Home'), img: OC.imagePath('core', 'places/home.svg') }); for (var i = 0; i < parts.length; i++) { From e5875fda385140698a76bddbad33b0a50350448c Mon Sep 17 00:00:00 2001 From: Jan-Christoph Borchardt Date: Wed, 17 Dec 2014 11:40:21 +0100 Subject: [PATCH 2/9] properly name form labels for the file selection --- apps/files/js/filelist.js | 1 + apps/files/templates/list.php | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/apps/files/js/filelist.js b/apps/files/js/filelist.js index b4702ce4f2..90d30507f4 100644 --- a/apps/files/js/filelist.js +++ b/apps/files/js/filelist.js @@ -710,6 +710,7 @@ '' ); } else { diff --git a/apps/files/templates/list.php b/apps/files/templates/list.php index a0138967cd..81e9c3fc18 100644 --- a/apps/files/templates/list.php +++ b/apps/files/templates/list.php @@ -57,7 +57,9 @@
- + t( 'Name' )); ?> From edc8967c93599b3df09414b6d22453a4505dc839 Mon Sep 17 00:00:00 2001 From: Jan-Christoph Borchardt Date: Wed, 17 Dec 2014 11:50:58 +0100 Subject: [PATCH 3/9] add text to Delete action --- apps/files/js/fileactions.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/apps/files/js/fileactions.js b/apps/files/js/fileactions.js index da48cf29be..82dabdfeae 100644 --- a/apps/files/js/fileactions.js +++ b/apps/files/js/fileactions.js @@ -289,7 +289,8 @@ } var $actionLink = $('' + '" class="action delete icon-delete">' + + '' ); var $container = context.$file.find('td:last'); $container.find('.delete').remove(); From 4eecb98b38bc1c679ef05c216fd4a9ead510971b Mon Sep 17 00:00:00 2001 From: Jan-Christoph Borchardt Date: Wed, 17 Dec 2014 11:52:45 +0100 Subject: [PATCH 4/9] add empty alt text for user image --- core/templates/layout.user.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/core/templates/layout.user.php b/core/templates/layout.user.php index d8129ecfc6..0a2bf63a89 100644 --- a/core/templates/layout.user.php +++ b/core/templates/layout.user.php @@ -61,7 +61,8 @@ From 4344b3d3cfd9f155899d2a7670f5936251fbc70f Mon Sep 17 00:00:00 2001 From: Jan-Christoph Borchardt Date: Wed, 17 Dec 2014 11:55:35 +0100 Subject: [PATCH 5/9] fix Delete action text being translatable --- apps/files/js/fileactions.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/apps/files/js/fileactions.js b/apps/files/js/fileactions.js index 82dabdfeae..e981ac625b 100644 --- a/apps/files/js/fileactions.js +++ b/apps/files/js/fileactions.js @@ -290,7 +290,8 @@ var $actionLink = $('' + - '' + '' + + '' ); var $container = context.$file.find('td:last'); $container.find('.delete').remove(); From 9f9aa44b577fc2efb2893f8f71f8bbb7770e68d7 Mon Sep 17 00:00:00 2001 From: Jan-Christoph Borchardt Date: Wed, 17 Dec 2014 12:05:45 +0100 Subject: [PATCH 6/9] add alt text to 'Cancel upload' button --- apps/files/templates/list.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/apps/files/templates/list.php b/apps/files/templates/list.php index 81e9c3fc18..bd27be8c5e 100644 --- a/apps/files/templates/list.php +++ b/apps/files/templates/list.php @@ -39,7 +39,8 @@
+ style="display:none" value="" + alt="t('Cancel upload'))?>" />
From 1b5f43e7c36f411e1abdf0fcdaec6e3e653c6dc7 Mon Sep 17 00:00:00 2001 From: Jan-Christoph Borchardt Date: Wed, 17 Dec 2014 12:20:38 +0100 Subject: [PATCH 7/9] add text to Settings button --- apps/files/templates/appnavigation.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/apps/files/templates/appnavigation.php b/apps/files/templates/appnavigation.php index 30f0a5afdf..aa2deea78e 100644 --- a/apps/files/templates/appnavigation.php +++ b/apps/files/templates/appnavigation.php @@ -6,7 +6,9 @@
- +

t('WebDAV'));?>

From 6f4ed59883c7cda899ccb49e60e34a8529ffbd18 Mon Sep 17 00:00:00 2001 From: Jan-Christoph Borchardt Date: Wed, 17 Dec 2014 14:12:13 +0100 Subject: [PATCH 8/9] use method to only visually hide elements, show only for screen reader --- apps/files/js/fileactions.js | 2 +- apps/files/js/filelist.js | 2 +- apps/files/templates/appnavigation.php | 2 +- apps/files/templates/list.php | 2 +- core/css/styles.css | 13 ++++++++++++- 5 files changed, 16 insertions(+), 5 deletions(-) diff --git a/apps/files/js/fileactions.js b/apps/files/js/fileactions.js index e981ac625b..875857745b 100644 --- a/apps/files/js/fileactions.js +++ b/apps/files/js/fileactions.js @@ -290,7 +290,7 @@ var $actionLink = $('' + - '' + + '' + escapeHTML(deleteTitle) + '' + '' ); var $container = context.$file.find('td:last'); diff --git a/apps/files/js/filelist.js b/apps/files/js/filelist.js index 90d30507f4..d8b8916752 100644 --- a/apps/files/js/filelist.js +++ b/apps/files/js/filelist.js @@ -710,7 +710,7 @@ '' ); } else { diff --git a/apps/files/templates/appnavigation.php b/apps/files/templates/appnavigation.php index aa2deea78e..faf2be39b0 100644 --- a/apps/files/templates/appnavigation.php +++ b/apps/files/templates/appnavigation.php @@ -7,7 +7,7 @@
diff --git a/apps/files/templates/list.php b/apps/files/templates/list.php index bd27be8c5e..a90ababf2b 100644 --- a/apps/files/templates/list.php +++ b/apps/files/templates/list.php @@ -59,7 +59,7 @@
t( 'Name' )); ?> diff --git a/core/css/styles.css b/core/css/styles.css index 7badfca6c1..856ba68def 100644 --- a/core/css/styles.css +++ b/core/css/styles.css @@ -711,7 +711,18 @@ label.infield { /* VARIOUS REUSABLE SELECTORS */ -.hidden { display:none; } +.hidden { + display: none; +} +.hidden-visually { + position: absolute; + left:-10000px; + top: auto; + width: 1px; + height: 1px; + overflow: hidden; +} + .bold { font-weight:bold; } .center { text-align:center; } .inlineblock { display: inline-block; } From 0c764bc39fb7637c48feb8b50bba47cb0f48d9ca Mon Sep 17 00:00:00 2001 From: Jan-Christoph Borchardt Date: Wed, 17 Dec 2014 14:49:13 +0100 Subject: [PATCH 9/9] add label for search field for screen readers --- core/templates/layout.user.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/core/templates/layout.user.php b/core/templates/layout.user.php index 0a2bf63a89..2d601b2293 100644 --- a/core/templates/layout.user.php +++ b/core/templates/layout.user.php @@ -91,6 +91,9 @@