From 83855c073bda187084ad644541f5c46465f16b8e Mon Sep 17 00:00:00 2001
From: Joas Schilling <nickvergessen@owncloud.com>
Date: Thu, 7 Jan 2016 14:55:23 +0100
Subject: [PATCH] Add a warning on the apps list when the version is missing

---
 settings/controller/appsettingscontroller.php |  3 +++
 settings/templates/apps.php                   | 12 ++++++++++++
 2 files changed, 15 insertions(+)

diff --git a/settings/controller/appsettingscontroller.php b/settings/controller/appsettingscontroller.php
index 765fe2d285..79b7589027 100644
--- a/settings/controller/appsettingscontroller.php
+++ b/settings/controller/appsettingscontroller.php
@@ -296,6 +296,9 @@ class AppSettingsController extends Controller {
 			$app['canInstall'] = empty($missing);
 			$app['missingDependencies'] = $missing;
 
+			$app['missingMinOwnCloudVersion'] = !isset($app['dependencies']['owncloud']['@attributes']['min-version']);
+			$app['missingMaxOwnCloudVersion'] = !isset($app['dependencies']['owncloud']['@attributes']['max-version']);
+
 			return $app;
 		}, $apps);
 
diff --git a/settings/templates/apps.php b/settings/templates/apps.php
index 7213d552c0..94efd76c7c 100644
--- a/settings/templates/apps.php
+++ b/settings/templates/apps.php
@@ -97,6 +97,18 @@ script(
 	<div class="app-description-toggle-show"><?php p($l->t("Show description …"));?></div>
 	<div class="app-description-toggle-hide hidden"><?php p($l->t("Hide description …"));?></div>
 
+	{{#if missingMinOwnCloudVersion}}
+		<div class="app-dependencies">
+			<p><?php p($l->t('This app has no minimum ownCloud version assigned. This will be an error in ownCloud 11 and later.')); ?></p>
+		</div>
+	{{else}}
+		{{#if missingMaxOwnCloudVersion}}
+			<div class="app-dependencies">
+				<p><?php p($l->t('This app has no maximum ownCloud version assigned. This will be an error in ownCloud 11 and later.')); ?></p>
+			</div>
+		{{/if}}
+	{{/if}}
+
 	{{#unless canInstall}}
 	<div class="app-dependencies">
 	<p><?php p($l->t('This app cannot be installed because the following dependencies are not fulfilled:')); ?></p>